make drawText calls non-virtual, to ease SkFont and TextBlob

make drawText calls non-virtual, to ease SkFont and TextBlob

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14307

[robertphillips, 2014-04-22 13:07:34]

lgtm

[reed1, 2014-04-22 13:46:47]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-04-22 13:46:53]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/243853006/1

[commit-bot: I haz the power, 2014-04-22 13:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-22 13:53:42]

Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s)
BuildTests
http://skia-tree-status.appspot.com/redirect/compile-buildbots/buildstatus?bu...

[reed1, 2014-04-22 17:39:34]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-04-22 17:39:50]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/243853006/20001

[commit-bot: I haz the power, 2014-04-22 19:03:26]

Change committed as 14307

[reed1, 2014-04-22 20:06:36]

A revert of this CL has been created in
https://codereview.chromium.org/247983003/ by reed@google.com.

The reason for reverting is: need to test more the code-path where we don't opt
into the new virtuals.

[bsalomon, 2014-04-22 20:21:06]

On 2014/04/22 20:06:36, reed1 wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/247983003/ by mailto:reed@google.com.
> 
> The reason for reverting is: need to test more the code-path where we don't
opt
> into the new virtuals.

Not sure if this is related to your comment about testing or not but this seemed
to cause regressions in the Chrome canary bot:

http://108.170.220.120:10117/builders/Canary-Chrome-Win7-Ninja-x86-SharedLib_...

[bsalomon, 2014-04-22 20:22:31]

On 2014/04/22 20:21:06, bsalomon wrote:
> On 2014/04/22 20:06:36, reed1 wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/247983003/ by mailto:reed@google.com.
> > 
> > The reason for reverting is: need to test more the code-path where we don't
> opt
> > into the new virtuals.
> 
> Not sure if this is related to your comment about testing or not but this
seemed
> to cause regressions in the Chrome canary bot:
> 
>
http://108.170.220.120:10117/builders/Canary-Chrome-Win7-Ninja-x86-SharedLib_...

And the windows builders, e.g.:

http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Debug-Exceptions/b...

Looks like the same set of errors as the canary

[reed1, 2014-04-22 21:09:03]

On 2014/04/22 20:22:31, bsalomon wrote:
> On 2014/04/22 20:21:06, bsalomon wrote:
> > On 2014/04/22 20:06:36, reed1 wrote:
> > > A revert of this CL has been created in
> > > https://codereview.chromium.org/247983003/ by mailto:reed@google.com.
> > > 
> > > The reason for reverting is: need to test more the code-path where we
don't
> > opt
> > > into the new virtuals.
> > 
> > Not sure if this is related to your comment about testing or not but this
> seemed
> > to cause regressions in the Chrome canary bot:
> > 
> >
>
http://108.170.220.120:10117/builders/Canary-Chrome-Win7-Ninja-x86-SharedLib_...
> 
> And the windows builders, e.g.:
> 
>
http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Debug-Exceptions/b...
> 
> Looks like the same set of errors as the canary

The win builder errors are from the experimental pdf code (do we need to keep
"fixing" it?)
The canary errors are due to my stated need to address building w/ and w/o the
guard