Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2438443005: MD Settings: Date and Time page, part 2/3 (Closed)

Created:
4 years, 2 months ago by michaelpg
Modified:
4 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, dcheng, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Date and Time page, part 2/3 Adds time zones and support for time zone auto-detection policies. Tests those things. BUG=546835 R=stevenjb@chromium.org TEST=CrSettingsDateTimePageTest CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a6e0c9138c3381f258149828c2a8b590ac4c45ba Cr-Commit-Position: refs/heads/master@{#427864}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix dropdown separately #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -97 lines) Patch
M chrome/browser/chromeos/system/timezone_util.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/timezone_util.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/compiled_resources2.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.html View 1 1 chunk +35 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.js View 1 2 chunks +142 lines, -68 lines 0 comments Download
M chrome/browser/resources/settings/md_select_css.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/date_time_handler.h View 2 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/date_time_handler.cc View 1 3 chunks +98 lines, -19 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 1 chunk +27 lines, -0 lines 0 comments Download
A chrome/test/data/webui/settings/date_time_page_tests.js View 1 chunk +239 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
stevenjb
lgtm w/ nits https://codereview.chromium.org/2438443005/diff/1/chrome/browser/resources/settings/controls/settings_dropdown_menu.js File chrome/browser/resources/settings/controls/settings_dropdown_menu.js (right): https://codereview.chromium.org/2438443005/diff/1/chrome/browser/resources/settings/controls/settings_dropdown_menu.js#newcode111 chrome/browser/resources/settings/controls/settings_dropdown_menu.js:111: this.selected_ = ''; Eww. Can we ...
4 years, 2 months ago (2016-10-21 20:16:40 UTC) #2
michaelpg
Thanks for the review. I moved the <settings-dropdown-menu> fix out and rebased (which got rid ...
4 years, 1 month ago (2016-10-25 00:35:16 UTC) #3
stevenjb
still lgtm
4 years, 1 month ago (2016-10-25 16:33:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438443005/40001
4 years, 1 month ago (2016-10-26 21:52:38 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-26 23:09:46 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 23:12:09 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a6e0c9138c3381f258149828c2a8b590ac4c45ba
Cr-Commit-Position: refs/heads/master@{#427864}

Powered by Google App Engine
This is Rietveld 408576698