MD Settings: Date and Time page, part 2/3

MD Settings: Date and Time page, part 2/3

Adds time zones and support for time zone auto-detection policies.
Tests those things.

BUG=546835
R=stevenjb@chromium.org
TEST=CrSettingsDateTimePageTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a6e0c9138c3381f258149828c2a8b590ac4c45ba
Cr-Commit-Position: refs/heads/master@{#427864}

[michaelpg, 2016-10-20 07:32:19]

Description was changed from

==========
MD Settings: Date and Time page, part 2/3

Adds time zones and support for time zone auto-detection policies.
Tests those things.

BUG=546835
R=stevenjb@chromium.org
TEST=CrSettingsDateTimePageTest
==========

to

==========
MD Settings: Date and Time page, part 2/3

Adds time zones and support for time zone auto-detection policies.
Tests those things.

BUG=546835
R=stevenjb@chromium.org
TEST=CrSettingsDateTimePageTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-10-21 20:16:40]

lgtm w/ nits

https://codereview.chromium.org/2438443005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/controls/settings_dropdown_menu.js
(right):

https://codereview.chromium.org/2438443005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:111:
this.selected_ = '';
Eww. Can we do:
if( == )
  this.notifyPath('selected_');
else
  this.selected_ = newSelected
?

https://codereview.chromium.org/2438443005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/date_time_page/date_time_page.js (right):

https://codereview.chromium.org/2438443005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/date_time_page/date_time_page.js:85: };
nit: Since this is frequently unused, maybe default to undefined and only set
the value in onTimeZoneAutoDetectPolicyChanged_ when appropriate?

[michaelpg, 2016-10-25 00:35:16]

Thanks for the review. I moved the <settings-dropdown-menu> fix out and rebased
(which got rid of the pesky hideTimeZoneDetection_ flag).

https://codereview.chromium.org/2438443005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/controls/settings_dropdown_menu.js
(right):

https://codereview.chromium.org/2438443005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:111:
this.selected_ = '';
On 2016/10/21 20:16:40, stevenjb wrote:
> Eww. Can we do:
> if( == )
>   this.notifyPath('selected_');
> else
>   this.selected_ = newSelected
> ?

Found a correct-er fix and rebased this patch on that one.

https://codereview.chromium.org/2438443005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/date_time_page/date_time_page.js (right):

https://codereview.chromium.org/2438443005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/date_time_page/date_time_page.js:85: };
On 2016/10/21 20:16:40, stevenjb wrote:
> nit: Since this is frequently unused, maybe default to undefined and only set
> the value in onTimeZoneAutoDetectPolicyChanged_ when appropriate?

Done.

[stevenjb, 2016-10-25 16:33:29]

still lgtm

[michaelpg, 2016-10-26 21:51:35]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-10-26 21:51:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2438443005/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-26 21:52:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 23:09:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 23:12:07]

Description was changed from

==========
MD Settings: Date and Time page, part 2/3

Adds time zones and support for time zone auto-detection policies.
Tests those things.

BUG=546835
R=stevenjb@chromium.org
TEST=CrSettingsDateTimePageTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Date and Time page, part 2/3

Adds time zones and support for time zone auto-detection policies.
Tests those things.

BUG=546835
R=stevenjb@chromium.org
TEST=CrSettingsDateTimePageTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a6e0c9138c3381f258149828c2a8b590ac4c45ba
Cr-Commit-Position: refs/heads/master@{#427864}
==========

[commit-bot: I haz the power, 2016-10-26 23:12:09]

Patchset 3 (id:??) landed as
https://crrev.com/a6e0c9138c3381f258149828c2a8b590ac4c45ba
Cr-Commit-Position: refs/heads/master@{#427864}