MD Settings: Show "Set date and time" button when relevant

MD Settings: Show "Set date and time" button when relevant

As in Options, show the "Set date and time" button if the date and time have
not been synced via network time. This launches an external WebUI dialog.

Follows "Date and Time page, part 2/3" to complete the Date & Time page.

BUG=546835
R=stevenjb@chromium.org
TEST=CrSettingsDateTimePageTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/90a1dfb820e82732bb603f6ea2dc6ebe3303215e
Cr-Commit-Position: refs/heads/master@{#430133}

[michaelpg, 2016-10-26 02:16:41]

Description was changed from

==========
MD Settings: Show "Set date and time" button when relevant

As in Options, show the "Set date and time" button if the date and time have
not been synced via network time. This launches an external WebUI dialog.

Follows "Date and Time page, part 2/3" to complete the Date & Time page.

BUG=546835
R=stevenjb@chromium.org
TEST=CrSettingsDateTimePageTest
==========

to

==========
MD Settings: Show "Set date and time" button when relevant

As in Options, show the "Set date and time" button if the date and time have
not been synced via network time. This launches an external WebUI dialog.

Follows "Date and Time page, part 2/3" to complete the Date & Time page.

BUG=546835
R=stevenjb@chromium.org
TEST=CrSettingsDateTimePageTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-10-26 02:18:07]

Patchset #2 (id:20001) has been deleted

[michaelpg, 2016-10-26 02:22:46]

PTAL. Pretty much the same logic as Options.

[stevenjb, 2016-10-26 19:36:21]

https://codereview.chromium.org/2447343002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/date_time_page/date_time_page.html
(right):

https://codereview.chromium.org/2447343002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/date_time_page/date_time_page.html:26: }
Use hidden=[[!canSetDateTime_]] instead to be consistent with everywhere else?

https://codereview.chromium.org/2447343002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/date_time_page/date_time_page.html:54: <div
class="start"><div>$i18n{setDateTime}</div></div>
nit: This is hard to read, can we put this on 3 lines instead?

[michaelpg, 2016-11-02 01:54:14]

https://codereview.chromium.org/2447343002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/date_time_page/date_time_page.html
(right):

https://codereview.chromium.org/2447343002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/date_time_page/date_time_page.html:26: }
On 2016/10/26 19:36:21, stevenjb wrote:
> Use hidden=[[!canSetDateTime_]] instead to be consistent with everywhere else?

Done.

https://codereview.chromium.org/2447343002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/date_time_page/date_time_page.html:54: <div
class="start"><div>$i18n{setDateTime}</div></div>
On 2016/10/26 19:36:21, stevenjb wrote:
> nit: This is hard to read, can we put this on 3 lines instead?

Done.

[michaelpg, 2016-11-02 01:54:17]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-11-02 01:54:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 01:54:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 01:54:40]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[michaelpg, 2016-11-02 02:06:38]

The CQ bit was checked by michaelpg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 02:06:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 03:19:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 03:19:16]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-11-03 01:45:47]

lgtm

[michaelpg, 2016-11-05 01:47:49]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-11-05 01:47:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2447343002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-05 01:48:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 02:53:56]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-05 02:56:19]

Description was changed from

==========
MD Settings: Show "Set date and time" button when relevant

As in Options, show the "Set date and time" button if the date and time have
not been synced via network time. This launches an external WebUI dialog.

Follows "Date and Time page, part 2/3" to complete the Date & Time page.

BUG=546835
R=stevenjb@chromium.org
TEST=CrSettingsDateTimePageTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Show "Set date and time" button when relevant

As in Options, show the "Set date and time" button if the date and time have
not been synced via network time. This launches an external WebUI dialog.

Follows "Date and Time page, part 2/3" to complete the Date & Time page.

BUG=546835
R=stevenjb@chromium.org
TEST=CrSettingsDateTimePageTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/90a1dfb820e82732bb603f6ea2dc6ebe3303215e
Cr-Commit-Position: refs/heads/master@{#430133}
==========

[commit-bot: I haz the power, 2016-11-05 02:56:21]

Patchset 4 (id:??) landed as
https://crrev.com/90a1dfb820e82732bb603f6ea2dc6ebe3303215e
Cr-Commit-Position: refs/heads/master@{#430133}