Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2438423002: MD Settings: Remove usage of 'autofocus' from settings-action-menu. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Remove usage of 'autofocus' from settings-action-menu. BUG=657234 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9811dce8931bffbbdc9ae70e8e362491c3de4157 Cr-Commit-Position: refs/heads/master@{#427248}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -38 lines) Patch
M chrome/browser/resources/settings/settings_action_menu.js View 1 4 chunks +5 lines, -26 lines 0 comments Download
M chrome/test/data/webui/settings/settings_action_menu_test.js View 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
dpapad
4 years, 2 months ago (2016-10-21 22:32:12 UTC) #5
dpapad
On 2016/10/21 at 22:32:12, dpapad wrote: > Friendly ping.
4 years, 1 month ago (2016-10-25 00:54:00 UTC) #8
Dan Beam
lgtm https://codereview.chromium.org/2438423002/diff/1/chrome/browser/resources/settings/settings_action_menu.js File chrome/browser/resources/settings/settings_action_menu.js (right): https://codereview.chromium.org/2438423002/diff/1/chrome/browser/resources/settings/settings_action_menu.js#newcode92 chrome/browser/resources/settings/settings_action_menu.js:92: // Array. don't really think this is a ...
4 years, 1 month ago (2016-10-25 00:56:11 UTC) #9
dpapad
https://codereview.chromium.org/2438423002/diff/1/chrome/browser/resources/settings/settings_action_menu.js File chrome/browser/resources/settings/settings_action_menu.js (right): https://codereview.chromium.org/2438423002/diff/1/chrome/browser/resources/settings/settings_action_menu.js#newcode92 chrome/browser/resources/settings/settings_action_menu.js:92: // Array. On 2016/10/25 at 00:56:10, Dan Beam wrote: ...
4 years, 1 month ago (2016-10-25 01:27:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438423002/20001
4 years, 1 month ago (2016-10-25 01:29:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 02:39:41 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 02:42:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9811dce8931bffbbdc9ae70e8e362491c3de4157
Cr-Commit-Position: refs/heads/master@{#427248}

Powered by Google App Engine
This is Rietveld 408576698