Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2912)

Unified Diff: chrome/test/data/webui/settings/settings_action_menu_test.js

Issue 2438423002: MD Settings: Remove usage of 'autofocus' from settings-action-menu. (Closed)
Patch Set: Nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_action_menu.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/settings_action_menu_test.js
diff --git a/chrome/test/data/webui/settings/settings_action_menu_test.js b/chrome/test/data/webui/settings/settings_action_menu_test.js
index 4115d8a36225159c9e80daa24ff8456bac303070..95ac624a133f052134b1a6e4104f83da33d1635b 100644
--- a/chrome/test/data/webui/settings/settings_action_menu_test.js
+++ b/chrome/test/data/webui/settings/settings_action_menu_test.js
@@ -17,6 +17,7 @@ suite('SettingsActionMenu', function() {
<button id="dots">...</button>
<dialog is="settings-action-menu">
<button class="dropdown-item">Un</button>
+ <hr>
<button class="dropdown-item">Dos</button>
<button class="dropdown-item">Tres</button>
</dialog>
@@ -33,32 +34,23 @@ suite('SettingsActionMenu', function() {
});
test('focus after showing', function() {
- /** @param {!HTMLElement} element */
- function assertFocused(element) {
- assertEquals(element, menu.root.activeElement);
- items.forEach(function(item, i) {
- assertEquals(element === item, item.hasAttribute('autofocus'));
- });
- }
-
menu.showAt(document.querySelector('#dots'));
- assertFocused(items[0]);
+ assertEquals(menu.root.activeElement, items[0]);
menu.close();
items[0].hidden = true;
menu.showAt(document.querySelector('#dots'));
- assertFocused(items[1]);
+ assertEquals(menu.root.activeElement, items[1]);
menu.close();
items[1].hidden = true;
menu.showAt(document.querySelector('#dots'));
- assertFocused(items[2]);
+ assertEquals(menu.root.activeElement, items[2]);
menu.close();
items[2].disabled = true;
menu.showAt(document.querySelector('#dots'));
assertEquals(null, menu.root.activeElement);
- assertEquals(0, menu.querySelectorAll('[autofocus]').length);
});
test('focus after down/up arrow', function() {
« no previous file with comments | « chrome/browser/resources/settings/settings_action_menu.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698