third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc - Issue 2438313003: [LayoutNG] Remove derived constraint spaces from opportunity iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2438313003: [LayoutNG] Remove derived constraint spaces from opportunity iterator. (Closed)

Patch Set: address comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

index 0f647bbb3eab231959b6fa7577c2aadd8ac16670..0ef199af7c946f75d61c022c37f6315f0eafe698 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

@@ -28,15 +28,6 @@ NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,

writing_mode_(writing_mode),

direction_(direction) {}

-NGConstraintSpace::NGConstraintSpace(const NGConstraintSpace& other,

- NGLogicalOffset offset,

- NGLogicalSize size)

- : physical_space_(other.MutablePhysicalSpace()),

- offset_(offset),

- size_(size),

- writing_mode_(other.WritingMode()),

- direction_(other.Direction()) {}

NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,

NGDirection direction,

const NGConstraintSpace& other,