Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2438313003: [LayoutNG] Remove derived constraint spaces from opportunity iterator. (Closed)
Patch Set: address comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ng/ng_constraint_space.h" 5 #include "core/layout/ng/ng_constraint_space.h"
6 6
7 #include "core/layout/LayoutBlock.h" 7 #include "core/layout/LayoutBlock.h"
8 #include "core/layout/LayoutView.h" 8 #include "core/layout/LayoutView.h"
9 #include "core/layout/ng/ng_layout_opportunity_iterator.h" 9 #include "core/layout/ng/ng_layout_opportunity_iterator.h"
10 #include "core/layout/ng/ng_units.h" 10 #include "core/layout/ng/ng_units.h"
(...skipping 10 matching lines...) Expand all
21 21
22 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode, 22 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
23 NGDirection direction, 23 NGDirection direction,
24 NGLogicalSize container_size) 24 NGLogicalSize container_size)
25 : physical_space_(new NGPhysicalConstraintSpace( 25 : physical_space_(new NGPhysicalConstraintSpace(
26 container_size.ConvertToPhysical(writing_mode))), 26 container_size.ConvertToPhysical(writing_mode))),
27 size_(container_size), 27 size_(container_size),
28 writing_mode_(writing_mode), 28 writing_mode_(writing_mode),
29 direction_(direction) {} 29 direction_(direction) {}
30 30
31 NGConstraintSpace::NGConstraintSpace(const NGConstraintSpace& other,
32 NGLogicalOffset offset,
33 NGLogicalSize size)
34 : physical_space_(other.MutablePhysicalSpace()),
35 offset_(offset),
36 size_(size),
37 writing_mode_(other.WritingMode()),
38 direction_(other.Direction()) {}
39
40 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode, 31 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
41 NGDirection direction, 32 NGDirection direction,
42 const NGConstraintSpace& other, 33 const NGConstraintSpace& other,
43 NGLogicalSize size) 34 NGLogicalSize size)
44 : size_(size), writing_mode_(writing_mode), direction_(direction) { 35 : size_(size), writing_mode_(writing_mode), direction_(direction) {
45 physical_space_ = 36 physical_space_ =
46 new NGPhysicalConstraintSpace(size.ConvertToPhysical(writing_mode)); 37 new NGPhysicalConstraintSpace(size.ConvertToPhysical(writing_mode));
47 for (const auto& exclusion : other.PhysicalSpace()->Exclusions()) { 38 for (const auto& exclusion : other.PhysicalSpace()->Exclusions()) {
48 physical_space_->AddExclusion(exclusion); 39 physical_space_->AddExclusion(exclusion);
49 } 40 }
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 178
188 String NGConstraintSpace::ToString() const { 179 String NGConstraintSpace::ToString() const {
189 return String::format("%s,%s %sx%s", 180 return String::format("%s,%s %sx%s",
190 offset_.inline_offset.toString().ascii().data(), 181 offset_.inline_offset.toString().ascii().data(),
191 offset_.block_offset.toString().ascii().data(), 182 offset_.block_offset.toString().ascii().data(),
192 size_.inline_size.toString().ascii().data(), 183 size_.inline_size.toString().ascii().data(),
193 size_.block_size.toString().ascii().data()); 184 size_.block_size.toString().ascii().data());
194 } 185 }
195 186
196 } // namespace blink 187 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698