Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2438253003: [css-grid] Use order-modified document order for m_gridItemsIndexesMap (Closed)

Created:
4 years, 2 months ago by Manuel Rego
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, Manuel Rego, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-paint_chromium.org, dshwang, jchaffraix+rendering, svillar, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Use order-modified document order for m_gridItemsIndexesMap We were storing the index in the DOM for the grid items in m_gridItemsIndexesMap. However, we can already store the index following the order-modified document order. This allows us to simplify the sorter in painting, as we don't need to check the order property now, just simply use the stored index. No new tests, as it's already covered by current tests. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/bb7071018e1fd8bf223b8ffff660883b7d17278d Cr-Commit-Position: refs/heads/master@{#426989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/GridPainter.cpp View 2 chunks +8 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Manuel Rego
This is small refactoring as @jfernandez will need to use this hash map for the ...
4 years, 2 months ago (2016-10-21 21:50:33 UTC) #4
cbiesinger
lgtm
4 years, 2 months ago (2016-10-21 22:10:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438253003/1
4 years, 2 months ago (2016-10-21 22:16:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/321718)
4 years, 2 months ago (2016-10-22 01:57:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438253003/1
4 years, 2 months ago (2016-10-22 06:35:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-22 07:47:58 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 07:50:02 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb7071018e1fd8bf223b8ffff660883b7d17278d
Cr-Commit-Position: refs/heads/master@{#426989}

Powered by Google App Engine
This is Rietveld 408576698