Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: pkg/barback/test/transformer/declare_assets.dart

Issue 243793005: Don't require Transformer methods to return Futures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/test/transformer/create_asset.dart ('k') | pkg/barback/test/transformer/declaring_bad.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/test/transformer/declare_assets.dart
diff --git a/pkg/barback/test/transformer/declare_assets.dart b/pkg/barback/test/transformer/declare_assets.dart
index d1158b8658d97889139cfc97adcca819c58978e0..4cf537034c56a1fdf3189c066710e6adced9abc6 100644
--- a/pkg/barback/test/transformer/declare_assets.dart
+++ b/pkg/barback/test/transformer/declare_assets.dart
@@ -4,10 +4,7 @@
library barback.test.transformer.declare_asset;
-import 'dart:async';
-
import 'package:barback/barback.dart';
-import 'package:barback/src/utils.dart';
import 'mock.dart';
@@ -27,19 +24,15 @@ class DeclareAssetsTransformer extends MockTransformer
this.emitted = (emitted == null ? declared : emitted)
.map((id) => new AssetId.parse(id)).toList();
- Future<bool> doIsPrimary(AssetId id) => new Future.value(true);
+ bool doIsPrimary(AssetId id) => true;
- Future doApply(Transform transform) {
- return newFuture(() {
- for (var id in emitted) {
- transform.addOutput(new Asset.fromString(id, id.toString()));
- }
- });
+ void doApply(Transform transform) {
+ for (var id in emitted) {
+ transform.addOutput(new Asset.fromString(id, id.toString()));
+ }
}
- Future declareOutputs(DeclaringTransform transform) {
- return newFuture(() {
- declared.forEach(transform.declareOutput);
- });
+ void declareOutputs(DeclaringTransform transform) {
+ declared.forEach(transform.declareOutput);
}
}
« no previous file with comments | « pkg/barback/test/transformer/create_asset.dart ('k') | pkg/barback/test/transformer/declaring_bad.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698