Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: pkg/barback/test/transformer/create_asset.dart

Issue 243793005: Don't require Transformer methods to return Futures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/barback/test/transformer/create_asset.dart
diff --git a/pkg/barback/test/transformer/create_asset.dart b/pkg/barback/test/transformer/create_asset.dart
index 5db8940fd7226c45615858c098edaf557084e1aa..82e80b37d4ba8a3e681ae5066126aa5482800c6d 100644
--- a/pkg/barback/test/transformer/create_asset.dart
+++ b/pkg/barback/test/transformer/create_asset.dart
@@ -4,10 +4,7 @@
library barback.test.transformer.create_asset;
-import 'dart:async';
-
import 'package:barback/barback.dart';
-import 'package:barback/src/utils.dart';
import 'mock.dart';
@@ -17,12 +14,10 @@ class CreateAssetTransformer extends MockTransformer {
CreateAssetTransformer(this.output);
- Future<bool> doIsPrimary(_) => new Future.value(true);
+ bool doIsPrimary(AssetId id) => true;
- Future doApply(Transform transform) {
- return newFuture(() {
- transform.addOutput(
- new Asset.fromString(new AssetId.parse(output), output));
- });
+ void doApply(Transform transform) {
+ transform.addOutput(
+ new Asset.fromString(new AssetId.parse(output), output));
}
}
« no previous file with comments | « pkg/barback/test/transformer/check_content_and_rename.dart ('k') | pkg/barback/test/transformer/declare_assets.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698