Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: pkg/barback/test/transformer/bad_log.dart

Issue 243793005: Don't require Transformer methods to return Futures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/test/transformer/bad.dart ('k') | pkg/barback/test/transformer/catch_asset_not_found.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/test/transformer/bad_log.dart
diff --git a/pkg/barback/test/transformer/bad_log.dart b/pkg/barback/test/transformer/bad_log.dart
index 5d77b937ab0c71943db351dd9a08fba514b52cb1..b84f105918ae833742f3c5076414d330545185ad 100644
--- a/pkg/barback/test/transformer/bad_log.dart
+++ b/pkg/barback/test/transformer/bad_log.dart
@@ -4,10 +4,7 @@
library barback.test.transformer.bad_log;
-import 'dart:async';
-
import 'package:barback/barback.dart';
-import 'package:barback/src/utils.dart';
import 'mock.dart';
@@ -19,17 +16,15 @@ class BadLogTransformer extends MockTransformer {
BadLogTransformer(this.outputs);
- Future<bool> doIsPrimary(AssetId id) => new Future.value(true);
+ bool doIsPrimary(AssetId id) => true;
- Future doApply(Transform transform) {
- return newFuture(() {
- transform.logger.error("first error");
- transform.logger.error("second error");
+ void doApply(Transform transform) {
+ transform.logger.error("first error");
+ transform.logger.error("second error");
- for (var output in outputs) {
- var id = new AssetId.parse(output);
- transform.addOutput(new Asset.fromString(id, output));
- }
- });
+ for (var output in outputs) {
+ var id = new AssetId.parse(output);
+ transform.addOutput(new Asset.fromString(id, output));
+ }
}
}
« no previous file with comments | « pkg/barback/test/transformer/bad.dart ('k') | pkg/barback/test/transformer/catch_asset_not_found.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698