Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: pkg/barback/test/transformer/bad.dart

Issue 243793005: Don't require Transformer methods to return Futures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/barback/test/transformer/bad.dart
diff --git a/pkg/barback/test/transformer/bad.dart b/pkg/barback/test/transformer/bad.dart
index a1e99cdc32331449f71181bfbd3ae3eabde9082b..0cc3496d059649e3487d64475a9f07649df9855f 100644
--- a/pkg/barback/test/transformer/bad.dart
+++ b/pkg/barback/test/transformer/bad.dart
@@ -4,10 +4,7 @@
library barback.test.transformer.bad;
-import 'dart:async';
-
import 'package:barback/barback.dart';
-import 'package:barback/src/utils.dart';
import 'mock.dart';
@@ -22,18 +19,16 @@ class BadTransformer extends MockTransformer {
BadTransformer(this.outputs);
- Future<bool> doIsPrimary(AssetId id) => new Future.value(true);
+ bool doIsPrimary(AssetId id) => true;
- Future doApply(Transform transform) {
- return newFuture(() {
- // Create the outputs first.
- for (var output in outputs) {
- var id = new AssetId.parse(output);
- transform.addOutput(new Asset.fromString(id, output));
- }
+ void doApply(Transform transform) {
+ // Create the outputs first.
+ for (var output in outputs) {
+ var id = new AssetId.parse(output);
+ transform.addOutput(new Asset.fromString(id, output));
+ }
- // Then fail.
- throw ERROR;
- });
+ // Then fail.
+ throw ERROR;
}
}
« no previous file with comments | « pkg/barback/test/package_graph/transform/transform_test.dart ('k') | pkg/barback/test/transformer/bad_log.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698