Don't require Transformer methods to return Futures.

pkg/barback/test/transformer_test.dart

Index: pkg/barback/test/transformer_test.dart
diff --git a/pkg/barback/test/transformer_test.dart b/pkg/barback/test/transformer_test.dart
index 3eb83a16dab0b9e2fd97d1b64e10494dfd3352e0..03b032d1795bfecac2498c29ef280b972ac90c22 100644
--- a/pkg/barback/test/transformer_test.dart
+++ b/pkg/barback/test/transformer_test.dart
@@ -7,6 +7,7 @@ library barback.test.transformer_test;
 import 'dart:async';
 
 import 'package:barback/barback.dart';
+import 'package:barback/src/utils.dart';
 import 'package:unittest/unittest.dart';
 
 import 'utils.dart';
@@ -17,24 +18,31 @@ main() {
   group("isPrimary", () {
     test("defaults to allowedExtensions", () {
       var transformer = new ExtensionTransformer(".txt .bin");

[Bob Nystrom, 2014/04/21 22:32:23]

Why not just make these sync?

[nweiz, 2014/04/21 22:46:24]

Done.

-      expect(transformer.isPrimary(new AssetId("pkg", "foo.txt")),
+      expect(syncFuture(() =>
+              transformer.isPrimary(new AssetId("pkg", "foo.txt"))),
           completion(isTrue));
 
-      expect(transformer.isPrimary(new AssetId("pkg", "foo.bin")),
+      expect(syncFuture(() =>
+              transformer.isPrimary(new AssetId("pkg", "foo.bin"))),
           completion(isTrue));
 
-      expect(transformer.isPrimary(new AssetId("pkg", "foo.nottxt")),
+      expect(syncFuture(() =>
+              transformer.isPrimary(new AssetId("pkg", "foo.nottxt"))),
           completion(isFalse));
     });
 
     test("supports multi-level extensions with allowedExtensions", () {
       var transformer = new ExtensionTransformer(".dart.js");
-      expect(transformer.isPrimary(new AssetId("pkg", "foo.dart.js")),
+      expect(syncFuture(() =>
+              transformer.isPrimary(new AssetId("pkg", "foo.dart.js"))),
           completion(isTrue));
 
-      expect(transformer.isPrimary(new AssetId("pkg", "foo.js")),
+      expect(syncFuture(() =>
+              transformer.isPrimary(new AssetId("pkg", "foo.js"))),
           completion(isFalse));
-      expect(transformer.isPrimary(new AssetId("pkg", "foo.dart")),
+
+      expect(syncFuture(() =>
+              transformer.isPrimary(new AssetId("pkg", "foo.dart"))),
           completion(isFalse));
     });
 
@@ -44,13 +52,16 @@ main() {
 
     test("allows all files if allowedExtensions is not overridden", () {
       var transformer = new MockTransformer();
-      expect(transformer.isPrimary(new AssetId("pkg", "foo.txt")),
+      expect(syncFuture(() =>
+              transformer.isPrimary(new AssetId("pkg", "foo.txt"))),
           completion(isTrue));
 
-      expect(transformer.isPrimary(new AssetId("pkg", "foo.bin")),
+      expect(syncFuture(() =>
+              transformer.isPrimary(new AssetId("pkg", "foo.bin"))),
           completion(isTrue));
 
-      expect(transformer.isPrimary(new AssetId("pkg", "anything")),
+      expect(syncFuture(() =>
+              transformer.isPrimary(new AssetId("pkg", "anything"))),
           completion(isTrue));
     });
   });