Chromium Code Reviews

Unified Diff: pkg/barback/test/transformer/rewrite.dart

Issue 243793005: Don't require Transformer methods to return Futures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« pkg/barback/test/transformer/bad.dart ('K') | « pkg/barback/test/transformer/one_to_many.dart ('k') | pkg/barback/test/transformer_test.dart » ('j') | pkg/barback/test/transformer_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/test/transformer/rewrite.dart
diff --git a/pkg/barback/test/transformer/rewrite.dart b/pkg/barback/test/transformer/rewrite.dart
index 995c94fff0c92cd474df4e4aa1cc3a71370de048..d25a552a29f8e55cd46983fd1df91f255fca2db3 100644
--- a/pkg/barback/test/transformer/rewrite.dart
+++ b/pkg/barback/test/transformer/rewrite.dart
@@ -25,8 +25,7 @@ class RewriteTransformer extends MockTransformer {
/// created for each input.
RewriteTransformer(this.from, this.to);
- Future<bool> doIsPrimary(AssetId id) =>
- new Future.value(id.extension == ".$from");
+ bool doIsPrimary(AssetId id) => id.extension == ".$from";
Future doApply(Transform transform) {
return getPrimary(transform).then((input) {
« pkg/barback/test/transformer/bad.dart ('K') | « pkg/barback/test/transformer/one_to_many.dart ('k') | pkg/barback/test/transformer_test.dart » ('j') | pkg/barback/test/transformer_test.dart » ('J')

Powered by Google App Engine