cc: Change ClipNode::applies_local_clip to a clip_type enum

cc: Change ClipNode::applies_local_clip to a clip_type enum

This change is in preparation for adding "expanding" clip nodes,
which will involve adding a new ClipType.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=653631
Committed: https://crrev.com/259f1e710e96ab0a0a9d14db19c82b78c9cbffe7
Cr-Commit-Position: refs/heads/master@{#427082}

[ajuma, 2016-10-20 00:37:35]

Description was changed from

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

WIP
==========

to

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

WIP
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[ajuma, 2016-10-20 00:37:36]

Description was changed from

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

WIP
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

WIP
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ajuma, 2016-10-21 22:46:04]

Description was changed from

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

WIP
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

This change is in preparation for adding "expanding" clip nodes,
which will involve adding a new ClipType.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=653631
==========

[ajuma, 2016-10-21 22:46:08]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 22:46:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-10-21 22:48:17]

Description was changed from

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

This change is in preparation for adding "expanding" clip nodes,
which will involve adding a new ClipType.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=653631
==========

to

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

This change is in preparation for adding "expanding" clip nodes,
which will involve adding a new ClipType.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=653631
==========

[ajuma, 2016-10-21 22:48:17]

ajuma@chromium.org changed reviewers:
+ jaydasika@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-10-21 23:20:59]

lgtm

https://codereview.chromium.org/2437923002/diff/1/cc/trees/property_tree_buil...
File cc/trees/property_tree_builder.cc (right):

https://codereview.chromium.org/2437923002/diff/1/cc/trees/property_tree_buil...
cc/trees/property_tree_builder.cc:372: DCHECK(parent->clip_type !=
ClipNode::ClipType::APPLIES_LOCAL_CLIP);
Nit : You can use DCHECK_NE here.

[ajuma, 2016-10-21 23:33:30]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 23:34:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-10-21 23:34:38]

ajuma@chromium.org changed reviewers:
+ pdr@chromium.org

[ajuma, 2016-10-21 23:35:30]

+pdr for Source/platform/graphics

https://codereview.chromium.org/2437923002/diff/1/cc/trees/property_tree_buil...
File cc/trees/property_tree_builder.cc (right):

https://codereview.chromium.org/2437923002/diff/1/cc/trees/property_tree_buil...
cc/trees/property_tree_builder.cc:372: DCHECK(parent->clip_type !=
ClipNode::ClipType::APPLIES_LOCAL_CLIP);
On 2016/10/21 23:20:58, jaydasika wrote:
> Nit : You can use DCHECK_NE here. 

Done.

[pdr., 2016-10-21 23:38:53]

On 2016/10/21 at 23:35:30, ajuma wrote:
> +pdr for Source/platform/graphics
> 
>
https://codereview.chromium.org/2437923002/diff/1/cc/trees/property_tree_buil...
> File cc/trees/property_tree_builder.cc (right):
> 
>
https://codereview.chromium.org/2437923002/diff/1/cc/trees/property_tree_buil...
> cc/trees/property_tree_builder.cc:372: DCHECK(parent->clip_type !=
ClipNode::ClipType::APPLIES_LOCAL_CLIP);
> On 2016/10/21 23:20:58, jaydasika wrote:
> > Nit : You can use DCHECK_NE here. 
> 
> Done.

LGTM

[ajuma, 2016-10-21 23:50:24]

The CQ bit was checked by ajuma@chromium.org

[ajuma, 2016-10-21 23:50:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
jaydasika@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2437923002/#ps40001
(title: "Fix Windows build")

[commit-bot: I haz the power, 2016-10-21 23:50:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 03:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 03:38:03]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ajuma, 2016-10-24 13:03:43]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2016-10-24 13:03:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 15:03:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 15:03:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ajuma, 2016-10-24 15:35:24]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2016-10-24 15:35:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 16:26:06]

Description was changed from

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

This change is in preparation for adding "expanding" clip nodes,
which will involve adding a new ClipType.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=653631
==========

to

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

This change is in preparation for adding "expanding" clip nodes,
which will involve adding a new ClipType.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=653631
==========

[commit-bot: I haz the power, 2016-10-24 16:26:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-24 16:49:57]

Description was changed from

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

This change is in preparation for adding "expanding" clip nodes,
which will involve adding a new ClipType.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=653631
==========

to

==========
cc: Change ClipNode::applies_local_clip to a clip_type enum

This change is in preparation for adding "expanding" clip nodes,
which will involve adding a new ClipType.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=653631

Committed: https://crrev.com/259f1e710e96ab0a0a9d14db19c82b78c9cbffe7
Cr-Commit-Position: refs/heads/master@{#427082}
==========

[commit-bot: I haz the power, 2016-10-24 16:49:58]

Patchset 3 (id:??) landed as
https://crrev.com/259f1e710e96ab0a0a9d14db19c82b78c9cbffe7
Cr-Commit-Position: refs/heads/master@{#427082}