Chromium Code Reviews| Index: media/base/audio_renderer_sink.h |
| diff --git a/media/base/audio_renderer_sink.h b/media/base/audio_renderer_sink.h |
| index f768b7cb1b42d2f0fbb4d7f192b2df5a1d7840ab..0912d847db1c05bebfdf19161830f34661cd04d0 100644 |
| --- a/media/base/audio_renderer_sink.h |
| +++ b/media/base/audio_renderer_sink.h |
| @@ -28,14 +28,15 @@ class AudioRendererSink |
| class RenderCallback { |
| public: |
| // Attempts to completely fill all channels of |dest|, returns actual |
| - // number of frames filled. |frames_skipped| contains the number of frames |
| + // number of frames filled. |prior_frames_skipped| contains the number of |
| + // frames |
| // the consumer has skipped, if any. |
| - // TODO(jameswest): Change to use the same signature as |
| - // AudioOutputStream::AudioSourceCallback::OnMoreData. |
| + // The |delay| argument represents audio device output latency, |
| + // |delay_timestamp| represents the time when |delay| was obtained. |
| virtual int Render(AudioBus* dest, |
| - uint32_t frames_delayed, |
| - uint32_t frames_skipped) = 0; |
| - |
| + base::TimeDelta delay, |
| + base::TimeTicks delay_timestamp, |
| + uint32_t prior_frames_skipped) = 0; |
|
James West
2016/10/21 19:40:17
Please use the same signature as AudioOutputStream
Mikhail
2016/10/24 19:50:24
Sure, I missed somehow that the arg order is diffe
|
| // Signals an error has occurred. |
| virtual void OnRenderError() = 0; |