[DevTools] Switch remote locations to Target domain.

[DevTools] Switch remote locations to Target domain.

- Moves setRemoteLocations from Browser to Target.
- Destroys agent host on remote connection closure, keeping devtools window alive.
- Fixes manager delegates not adding themselves as observers.
- Cleans up external agent hosts on detaches.

BUG=648775
TBR=bauerb@chromium.org

Committed: https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41
Cr-Commit-Position: refs/heads/master@{#426391}

[dgozman, 2016-10-19 20:36:28]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 20:37:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-10-19 21:18:33]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-10-19 21:18:34]

Could you please take a look?

[commit-bot: I haz the power, 2016-10-19 21:40:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 21:40:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-10-19 23:13:19]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 23:14:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-10-20 00:19:33]

lgtm

https://codereview.chromium.org/2437633003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js
(left):

https://codereview.chromium.org/2437633003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js:33:
target.connection().dispatch(message);
Lets remove target.connection accessor.

https://codereview.chromium.org/2437633003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js
(right):

https://codereview.chromium.org/2437633003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js:182:
connection._reportClosed();
This also calls dispose.

https://codereview.chromium.org/2437633003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js:187:
target.dispose();
make it private.

[commit-bot: I haz the power, 2016-10-20 01:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 01:06:41]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-10-20 01:10:57]

https://codereview.chromium.org/2437633003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js
(right):

https://codereview.chromium.org/2437633003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js:182:
connection._reportClosed();
On 2016/10/20 00:19:32, pfeldman wrote:
> This also calls dispose.

Done.

[dgozman, 2016-10-20 01:15:19]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-10-20 01:15:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2437633003/#ps40001
(title: "removed dispose")

[commit-bot: I haz the power, 2016-10-20 01:15:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 02:07:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 02:07:52]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgozman, 2016-10-20 03:22:18]

Description was changed from

==========
[DevTools] Switch remote locations to Target domain.

- Moves setRemoteLocations from Browser to Target.
- Destroys agent host on remote connection closure, keeping devtools window
alive.
- Fixes manager delegates not adding themselves as observers.
- Cleans up external agent hosts on detaches.

BUG=648775
==========

to

==========
[DevTools] Switch remote locations to Target domain.

- Moves setRemoteLocations from Browser to Target.
- Destroys agent host on remote connection closure, keeping devtools window
alive.
- Fixes manager delegates not adding themselves as observers.
- Cleans up external agent hosts on detaches.

BUG=648775
TBR=bauerb@chromium.org
==========

[dgozman, 2016-10-20 03:22:23]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-10-20 03:22:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 03:39:48]

Description was changed from

==========
[DevTools] Switch remote locations to Target domain.

- Moves setRemoteLocations from Browser to Target.
- Destroys agent host on remote connection closure, keeping devtools window
alive.
- Fixes manager delegates not adding themselves as observers.
- Cleans up external agent hosts on detaches.

BUG=648775
TBR=bauerb@chromium.org
==========

to

==========
[DevTools] Switch remote locations to Target domain.

- Moves setRemoteLocations from Browser to Target.
- Destroys agent host on remote connection closure, keeping devtools window
alive.
- Fixes manager delegates not adding themselves as observers.
- Cleans up external agent hosts on detaches.

BUG=648775
TBR=bauerb@chromium.org
==========

[commit-bot: I haz the power, 2016-10-20 03:39:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:15:05]

Description was changed from

==========
[DevTools] Switch remote locations to Target domain.

- Moves setRemoteLocations from Browser to Target.
- Destroys agent host on remote connection closure, keeping devtools window
alive.
- Fixes manager delegates not adding themselves as observers.
- Cleans up external agent hosts on detaches.

BUG=648775
TBR=bauerb@chromium.org
==========

to

==========
[DevTools] Switch remote locations to Target domain.

- Moves setRemoteLocations from Browser to Target.
- Destroys agent host on remote connection closure, keeping devtools window
alive.
- Fixes manager delegates not adding themselves as observers.
- Cleans up external agent hosts on detaches.

BUG=648775
TBR=bauerb@chromium.org

Committed: https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41
Cr-Commit-Position: refs/heads/master@{#426391}
==========

[commit-bot: I haz the power, 2016-10-21 13:15:06]

Patchset 3 (id:??) landed as
https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41
Cr-Commit-Position: refs/heads/master@{#426391}