Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: content/browser/devtools/protocol/target_handler.cc

Issue 2437633003: [DevTools] Switch remote locations to Target domain. (Closed)
Patch Set: removed dispose Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/target_handler.cc
diff --git a/content/browser/devtools/protocol/target_handler.cc b/content/browser/devtools/protocol/target_handler.cc
index f6f57ad99d6f8935036e1d2230863114c5cfbb48..413a6e6f9f21db4780a827729ff032f8dc3834db 100644
--- a/content/browser/devtools/protocol/target_handler.cc
+++ b/content/browser/devtools/protocol/target_handler.cc
@@ -109,6 +109,9 @@ void TargetHandler::SetClient(std::unique_ptr<Client> client) {
void TargetHandler::Detached() {
SetAutoAttach(false, false);
SetDiscoverTargets(false);
+ for (const auto& id_host : attached_hosts_)
+ id_host.second->DetachClient(this);
+ attached_hosts_.clear();
}
void TargetHandler::UpdateServiceWorkers() {
@@ -279,6 +282,11 @@ Response TargetHandler::SetAttachToFrames(bool value) {
return Response::OK();
}
+Response TargetHandler::SetRemoteLocations(
+ const std::vector<std::unique_ptr<base::DictionaryValue>>& locations) {
+ return Response::ServerError("Not supported");
+}
+
Response TargetHandler::AttachToTarget(const std::string& target_id,
bool* out_success) {
auto it = reported_hosts_.find(target_id);
« no previous file with comments | « content/browser/devtools/protocol/target_handler.h ('k') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698