Removing the dependency on //third_party/webrtc:webrtc and replacing with rtc_base.

Removing the dependency on //third_party/webrtc:webrtc and replacing with rtc_base.

R=sergeyu@chromium.org

BUG=653612
Committed: https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02
Cr-Commit-Position: refs/heads/master@{#427371}

[nicholss, 2016-10-19 19:47:36]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 19:48:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nicholss, 2016-10-19 21:09:42]

Locally this CL allows me to build and link the :remoting_all target for iOS.

PTAL!

[commit-bot: I haz the power, 2016-10-19 21:24:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 21:24:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nicholss, 2016-10-19 21:39:35]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 21:40:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sergey Ulanov, 2016-10-19 22:04:45]

Looks good, but it fails to build on android. I think you need to add dependency
on third_party/webrtc/modules/desktop_capture in remoting/client

https://codereview.chromium.org/2437453004/diff/1/remoting/protocol/ice_conne...
File remoting/protocol/ice_connection_to_client.cc (right):

https://codereview.chromium.org/2437453004/diff/1/remoting/protocol/ice_conne...
remoting/protocol/ice_connection_to_client.cc:35: #if defined(OS_IOS)
Maybe add a note here that AudioEncoderOpus is not compiled on iOS to avoid
dependency on media

https://codereview.chromium.org/2437453004/diff/1/remoting/test/app_remoting_...
File remoting/test/app_remoting_test_driver.cc (right):

https://codereview.chromium.org/2437453004/diff/1/remoting/test/app_remoting_...
remoting/test/app_remoting_test_driver.cc:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
FWIW I think we should be able to just remove this file.

[joedow, 2016-10-19 22:10:03]

joedow@chromium.org changed reviewers:
+ joedow@chromium.org

[joedow, 2016-10-19 22:10:03]

https://codereview.chromium.org/2437453004/diff/1/remoting/test/app_remoting_...
File remoting/test/app_remoting_test_driver.cc (right):

https://codereview.chromium.org/2437453004/diff/1/remoting/test/app_remoting_...
remoting/test/app_remoting_test_driver.cc:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/10/19 22:04:45, Sergey Ulanov wrote:
> FWIW I think we should be able to just remove this file.

I left this file in place as Mike was interested in seeing if he wanted to reuse
it.  Please check with him before removing it.

Either way, I would extract this target out and perhaps only build it on Linux. 
It could be used for a base of a new tool but doesn't need to build everywhere.

[nicholss, 2016-10-19 22:32:02]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 22:33:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 22:44:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:44:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[nicholss, 2016-10-19 22:52:42]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 22:53:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 23:03:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 23:03:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nicholss, 2016-10-19 23:21:52]

On 2016/10/19 22:10:03, joedow wrote:
>
https://codereview.chromium.org/2437453004/diff/1/remoting/test/app_remoting_...
> File remoting/test/app_remoting_test_driver.cc (right):
> 
>
https://codereview.chromium.org/2437453004/diff/1/remoting/test/app_remoting_...
> remoting/test/app_remoting_test_driver.cc:1: // Copyright 2015 The Chromium
> Authors. All rights reserved.
> On 2016/10/19 22:04:45, Sergey Ulanov wrote:
> > FWIW I think we should be able to just remove this file.
> 
> I left this file in place as Mike was interested in seeing if he wanted to
reuse
> it.  Please check with him before removing it.
> 
> Either way, I would extract this target out and perhaps only build it on
Linux. 
> It could be used for a base of a new tool but doesn't need to build
everywhere.

Sergey is going to make a change to the webrtc :primitives side to fix the
android error.

[Sergey Ulanov, 2016-10-21 18:41:19]

lgtm

[nicholss, 2016-10-24 19:37:32]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 19:38:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 19:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 19:44:16]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nicholss, 2016-10-24 19:48:09]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 19:48:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:43:55]

Dry run: This issue passed the CQ dry run.

[nicholss, 2016-10-25 15:59:42]

The CQ bit was checked by nicholss@chromium.org

[nicholss, 2016-10-25 15:59:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2437453004/#ps60001
(title: "Fixing :: typo.")

[commit-bot: I haz the power, 2016-10-25 16:00:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 16:05:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-25 16:14:43]

Description was changed from

==========
Removing the dependency on //third_party/webrtc:webrtc and replacing with
rtc_base.

R=sergeyu@chromium.org

BUG=653612
==========

to

==========
Removing the dependency on //third_party/webrtc:webrtc and replacing with
rtc_base.

R=sergeyu@chromium.org

BUG=653612

Committed: https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02
Cr-Commit-Position: refs/heads/master@{#427371}
==========

[commit-bot: I haz the power, 2016-10-25 16:14:45]

Patchset 4 (id:??) landed as
https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02
Cr-Commit-Position: refs/heads/master@{#427371}