Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: remoting/protocol/ice_connection_to_client.cc

Issue 2437453004: Removing the dependency on //third_party/webrtc:webrtc and replacing with rtc_base. (Closed)
Patch Set: Fixing :: typo. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/codec/BUILD.gn ('k') | remoting/protocol/webrtc_audio_module.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/ice_connection_to_client.cc
diff --git a/remoting/protocol/ice_connection_to_client.cc b/remoting/protocol/ice_connection_to_client.cc
index c4a42f16cd9cd2b9fbdd789eba31c38af444b4ff..037e80550fa138af9eab0b70c376a9d3388c141d 100644
--- a/remoting/protocol/ice_connection_to_client.cc
+++ b/remoting/protocol/ice_connection_to_client.cc
@@ -32,11 +32,17 @@ namespace {
std::unique_ptr<AudioEncoder> CreateAudioEncoder(
const protocol::SessionConfig& config) {
+#if defined(OS_IOS)
+ // TODO(nicholss): iOS should not use Opus. This is to prevent us from
+ // depending on //media. In the future we will use webrtc for conneciton
+ // and this will be a non-issue.
+ return nullptr;
+#else
const protocol::ChannelConfig& audio_config = config.audio_config();
-
if (audio_config.codec == protocol::ChannelConfig::CODEC_OPUS) {
return base::WrapUnique(new AudioEncoderOpus());
}
+#endif
NOTREACHED();
return nullptr;
« no previous file with comments | « remoting/codec/BUILD.gn ('k') | remoting/protocol/webrtc_audio_module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698