Fix unscrollable scrollers after closing a <dialog>.

Fix unscrollable scrollers after closing a <dialog>.

Inertness of a scroller can change without causing it to be laid out, if a
dialog is added or removed from Document::m_topLayerElements.  Checking
inertness in PLSA::updateScrollableAreaSet led to stale compositing state.

This patch updates PLSA to ignore inertness.  This means scrollers will remain
in FrameView::m_scrollableAreas even when covered by a dialog.  That should be
ok, since the ::backdrop element prevents them from actually receiving input.

BUG=633520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/3f34d9380173cbb2b36d76a859a477472e80ae61
Cr-Commit-Position: refs/heads/master@{#426975}

[skobes, 2016-10-21 03:25:30]

Description was changed from

==========
[WIP] Ignore visibleToHitTesting in updateScrollableAreaSet?
==========

to

==========
[WIP] Ignore visibleToHitTesting in updateScrollableAreaSet?
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[skobes, 2016-10-21 03:25:34]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 03:26:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 03:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 03:41:31]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[skobes, 2016-10-21 04:13:52]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 04:14:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2016-10-21 04:16:53]

Patchset #1 (id:1) has been deleted

[skobes, 2016-10-21 04:27:17]

Description was changed from

==========
[WIP] Ignore visibleToHitTesting in updateScrollableAreaSet?
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix unscrollable scrollers after closing a <dialog>.

Inertness of a scroller can change without causing it to be laid out, if a
dialog is added or removed from Document::m_topLayerElements.  Checking
inertness in PLSA::updateScrollableAreaSet led to stale compositing state.

This patch updates PLSA to ignore inertness.  This means scrollers will remain
in FrameView::m_scrollableAreas even when covered by a dialog.  That should be
ok, since the ::backdrop element prevents them from actually receiving input.

BUG=633520
==========

[commit-bot: I haz the power, 2016-10-21 04:35:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 04:35:09]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[skobes, 2016-10-21 05:16:32]

Description was changed from

==========
Fix unscrollable scrollers after closing a <dialog>.

Inertness of a scroller can change without causing it to be laid out, if a
dialog is added or removed from Document::m_topLayerElements.  Checking
inertness in PLSA::updateScrollableAreaSet led to stale compositing state.

This patch updates PLSA to ignore inertness.  This means scrollers will remain
in FrameView::m_scrollableAreas even when covered by a dialog.  That should be
ok, since the ::backdrop element prevents them from actually receiving input.

BUG=633520
==========

to

==========
Fix unscrollable scrollers after closing a <dialog>.

Inertness of a scroller can change without causing it to be laid out, if a
dialog is added or removed from Document::m_topLayerElements.  Checking
inertness in PLSA::updateScrollableAreaSet led to stale compositing state.

This patch updates PLSA to ignore inertness.  This means scrollers will remain
in FrameView::m_scrollableAreas even when covered by a dialog.  That should be
ok, since the ::backdrop element prevents them from actually receiving input.

BUG=633520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[skobes, 2016-10-21 05:16:58]

Patchset #1 (id:20001) has been deleted

[skobes, 2016-10-21 05:17:15]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 05:17:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2016-10-21 05:18:22]

skobes@chromium.org changed reviewers:
+ szager@chromium.org

[commit-bot: I haz the power, 2016-10-21 06:47:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 06:47:16]

Dry run: This issue passed the CQ dry run.

[szager1, 2016-10-22 00:14:10]

lgtm, although I think it would be cleaner to do this:

ComputedStyle.cpp:

bool visibleToHitTesting() const {
  return visibility() == EVisibility::Visible && pointerEvents() != PE_NONE;
}

LayoutObject.h:

bool visibleToHitTesting const {
  return style()->visibleToHitTesting && !isInert();
}

PaintLayerScrollableArea.cpp:

bool isVisibleToHitTest = box().style()->visibleToHitTesting();

[skobes, 2016-10-22 01:52:08]

On 2016/10/22 00:14:10, szager1 wrote:
> lgtm, although I think it would be cleaner to do this:
> 
> ComputedStyle.cpp:
> 
> bool visibleToHitTesting() const {
>   return visibility() == EVisibility::Visible && pointerEvents() != PE_NONE;
> }
> 
> LayoutObject.h:
> 
> bool visibleToHitTesting const {
>   return style()->visibleToHitTesting && !isInert();
> }
> 
> PaintLayerScrollableArea.cpp:
> 
> bool isVisibleToHitTest = box().style()->visibleToHitTesting();

Done.

[skobes, 2016-10-22 01:52:12]

The CQ bit was checked by skobes@chromium.org

[skobes, 2016-10-22 01:52:12]

The patchset sent to the CQ was uploaded after l-g-t-m from szager@chromium.org
Link to the patchset: https://codereview.chromium.org/2437303002/#ps60001
(title: "address review comments")

[commit-bot: I haz the power, 2016-10-22 01:52:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 05:02:58]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-22 05:04:54]

Description was changed from

==========
Fix unscrollable scrollers after closing a <dialog>.

Inertness of a scroller can change without causing it to be laid out, if a
dialog is added or removed from Document::m_topLayerElements.  Checking
inertness in PLSA::updateScrollableAreaSet led to stale compositing state.

This patch updates PLSA to ignore inertness.  This means scrollers will remain
in FrameView::m_scrollableAreas even when covered by a dialog.  That should be
ok, since the ::backdrop element prevents them from actually receiving input.

BUG=633520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix unscrollable scrollers after closing a <dialog>.

Inertness of a scroller can change without causing it to be laid out, if a
dialog is added or removed from Document::m_topLayerElements.  Checking
inertness in PLSA::updateScrollableAreaSet led to stale compositing state.

This patch updates PLSA to ignore inertness.  This means scrollers will remain
in FrameView::m_scrollableAreas even when covered by a dialog.  That should be
ok, since the ::backdrop element prevents them from actually receiving input.

BUG=633520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/3f34d9380173cbb2b36d76a859a477472e80ae61
Cr-Commit-Position: refs/heads/master@{#426975}
==========

[commit-bot: I haz the power, 2016-10-22 05:04:55]

Patchset 2 (id:??) landed as
https://crrev.com/3f34d9380173cbb2b36d76a859a477472e80ae61
Cr-Commit-Position: refs/heads/master@{#426975}