Revert of Make PaymentOption store a Drawable instead of id (patchset #4 id:100001 of https://codereview.chromium.org/2436883002/ )
Reason for revert:
This broke internal class (which relied on 'icon' being int). Please coordinate with rouslan@ to push a fix right after relanding.
Original issue's description:
> Make PaymentOption store a Drawable instead of id
>
> Make PaymentOption store a Drawable instead of id for the icon.
> This will allow to use icons not contained in the default resources.
>
> BUG=587995TBR=rouslan@chromium.org,miguelg@chromium.org,tedchoc@chromium.org,rob.buis@samsung.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=587995
Committed: https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f
Cr-Commit-Position: refs/heads/master@{#426618}
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago
(2016-10-20 22:19:15 UTC)
#5
No L-G-T-M from a valid reviewer yet.
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
please use gerrit instead
lgtm I will reland and fix the internals shortly sometime on Friday.
4 years, 2 months ago
(2016-10-20 22:20:09 UTC)
#6
lgtm
I will reland and fix the internals shortly sometime on Friday.
Dmitry Skiba
The CQ bit was checked by dskiba@google.com
4 years, 2 months ago
(2016-10-20 22:20:23 UTC)
#7
4 years, 2 months ago
(2016-10-20 22:22:19 UTC)
#10
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of Make PaymentOption store a Drawable instead of id ...
4 years, 2 months ago
(2016-10-21 13:23:28 UTC)
#11
Message was sent while issue was closed.
Description was changed from
==========
Revert of Make PaymentOption store a Drawable instead of id (patchset #4
id:100001 of https://codereview.chromium.org/2436883002/ )
Reason for revert:
This broke internal class (which relied on 'icon' being int). Please coordinate
with rouslan@ to push a fix right after relanding.
Original issue's description:
> Make PaymentOption store a Drawable instead of id
>
> Make PaymentOption store a Drawable instead of id for the icon.
> This will allow to use icons not contained in the default resources.
>
> BUG=587995
TBR=rouslan@chromium.org,miguelg@chromium.org,tedchoc@chromium.org,rob.buis@s...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=587995
==========
to
==========
Revert of Make PaymentOption store a Drawable instead of id (patchset #4
id:100001 of https://codereview.chromium.org/2436883002/ )
Reason for revert:
This broke internal class (which relied on 'icon' being int). Please coordinate
with rouslan@ to push a fix right after relanding.
Original issue's description:
> Make PaymentOption store a Drawable instead of id
>
> Make PaymentOption store a Drawable instead of id for the icon.
> This will allow to use icons not contained in the default resources.
>
> BUG=587995
TBR=rouslan@chromium.org,miguelg@chromium.org,tedchoc@chromium.org,rob.buis@s...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=587995
Committed: https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f
Cr-Commit-Position: refs/heads/master@{#426618}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f Cr-Commit-Position: refs/heads/master@{#426618}
4 years, 2 months ago
(2016-10-21 13:23:29 UTC)
#12
Issue 2437223002: Revert of Make PaymentOption store a Drawable instead of id
(Closed)
Created 4 years, 2 months ago by Dmitry Skiba
Modified 4 years, 2 months ago
Reviewers: please use gerrit instead, Miguel Garcia, Ted C, rwlbuis
Base URL:
Comments: 0