Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: pkg/analysis_server/test/mocks.dart

Issue 243703008: Eliminate nondeterminism from analysis server unit tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/mocks.dart
diff --git a/pkg/analysis_server/test/mocks.dart b/pkg/analysis_server/test/mocks.dart
index f6e6452addee0d03f543e7f5a7b59a1a876231df..4ada5ad642ee32665063a45fdce5d52b080a0657 100644
--- a/pkg/analysis_server/test/mocks.dart
+++ b/pkg/analysis_server/test/mocks.dart
@@ -31,6 +31,20 @@ String get sdkPath {
}
/**
+ * Returns a [Future] that completes after pumping the event queue [times]
+ * times. By default, this should pump the event queue enough times to allow
+ * any code to run, as long as it's not waiting on some external event.
+ */
+Future pumpEventQueue([int times = 20]) {
+ if (times == 0) return new Future.value();
+ // We use a delayed future to allow microtask events to finish. The
+ // Future.value or Future() constructors use scheduleMicrotask themselves and
+ // would therefore not wait for microtask callbacks that are scheduled after
+ // invoking this method.
+ return new Future.delayed(Duration.ZERO, () => pumpEventQueue(times - 1));
+}
+
+/**
* A mock [WebSocket] for testing.
*/
class MockSocket<T> implements WebSocket {
@@ -69,6 +83,17 @@ class MockSocket<T> implements WebSocket {
noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
}
+class NoResponseException implements Exception {
+ /** The request that was not responded to. */
Brian Wilkerson 2014/04/21 14:18:05 I don't know for sure, but I suspect that this sho
+ final Request request;
+
+ NoResponseException(this.request);
+
+ String toString() {
+ return "NoResponseException after request ${request.toJson()}";
+ }
+}
+
/**
* A mock [ServerCommunicationChannel] for testing [AnalysisServer].
*/
@@ -100,7 +125,10 @@ class MockServerChannel implements ServerCommunicationChannel {
var id = request.id;
// Wrap send request in future to simulate websocket
new Future(() => requestController.add(request));
- return responseController.stream.firstWhere((response) => response.id == id);
+ pumpEventQueue().then((_) => responseController.addError(
+ new NoResponseException(request)));
+ return responseController.stream.firstWhere((response) => response.id == id
+ );
}
@override

Powered by Google App Engine
This is Rietveld 408576698