Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: pkg/analysis_server/test/analysis_server_test.dart

Issue 243703008: Eliminate nondeterminism from analysis server unit tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/mocks.dart » ('j') | pkg/analysis_server/test/mocks.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/analysis_server_test.dart
diff --git a/pkg/analysis_server/test/analysis_server_test.dart b/pkg/analysis_server/test/analysis_server_test.dart
index 538267c394cd90f93176f86332ba1701551f4269..eeaebdf09a15f0439405c69b59304f46fa8b3a0e 100644
--- a/pkg/analysis_server/test/analysis_server_test.dart
+++ b/pkg/analysis_server/test/analysis_server_test.dart
@@ -16,7 +16,7 @@ import 'mocks.dart';
main() {
group('AnalysisServer', () {
setUp(AnalysisServerTest.setUp);
-// test('createContext', AnalysisServerTest.createContext);
+ test('createContext', AnalysisServerTest.createContext);
test('echo', AnalysisServerTest.echo);
test('shutdown', AnalysisServerTest.shutdown);
test('unknownRequest', AnalysisServerTest.unknownRequest);
@@ -38,7 +38,6 @@ class AnalysisServerTest {
request.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath);
request.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, 'ctx');
return channel.sendRequest(request)
- .timeout(new Duration(seconds: 1))
danrubel 2014/04/21 16:59:10 If for some reason, the server completes normally
.then((Response response) {
expect(response.id, equals('my27'));
expect(response.error, isNull);
@@ -49,7 +48,6 @@ class AnalysisServerTest {
server.handlers = [new EchoHandler()];
var request = new Request('my22', 'echo');
return channel.sendRequest(request)
- .timeout(new Duration(seconds: 1))
.then((Response response) {
expect(response.id, equals('my22'));
expect(response.error, isNull);
@@ -61,7 +59,6 @@ class AnalysisServerTest {
var request = new Request('my28', ServerDomainHandler.SHUTDOWN_METHOD);
request.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, '');
return channel.sendRequest(request)
- .timeout(new Duration(seconds: 1))
.then((Response response) {
expect(response.id, equals('my28'));
expect(response.error, isNull);
@@ -72,7 +69,6 @@ class AnalysisServerTest {
server.handlers = [new EchoHandler()];
var request = new Request('my22', 'randomRequest');
return channel.sendRequest(request)
- .timeout(new Duration(seconds: 1))
.then((Response response) {
expect(response.id, equals('my22'));
expect(response.error, isNotNull);
« no previous file with comments | « no previous file | pkg/analysis_server/test/mocks.dart » ('j') | pkg/analysis_server/test/mocks.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698