Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 243703005: [fsp] [recommit #2] Add an initial AsyncFileUtil. (Closed)

Created:
6 years, 8 months ago by mtomasz
Modified:
6 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[fsp] [recommit #2] Add an initial AsyncFileUtil. This patch adds the AsyncFileUtil implementation for the file system provider. It does not communicate with the file system provider service yet. Currently, for not supported operations SECURITY error is returned. For allowed, but not implemented operations, it is NOT_FOUND error. Unit tests are quite trivial at this stage, but they will grow once more operations are implemented. This patch has been previously committed and reverted due to test failures. See: https://codereview.chromium.org/236303017/ Later, this patch got again reverted because of ASAN failures. See: https://codereview.chromium.org/242493002/ TEST=unit_test: FileSystemProviderAsyncFileUtilTest* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264962

Patch Set 1 #

Total comments: 1

Messages

Total messages: 5 (0 generated)
mtomasz
@kinaba: PTAL. Thanks. https://codereview.chromium.org/243703005/diff/1/chrome/browser/chromeos/fileapi/file_system_backend.cc File chrome/browser/chromeos/fileapi/file_system_backend.cc (right): https://codereview.chromium.org/243703005/diff/1/chrome/browser/chromeos/fileapi/file_system_backend.cc#newcode54 chrome/browser/chromeos/fileapi/file_system_backend.cc:54: file_system_provider_delegate_(file_system_provider_delegate), @kinaba: This was missing, causing ...
6 years, 8 months ago (2014-04-21 01:09:35 UTC) #1
kinaba
lgtm
6 years, 8 months ago (2014-04-21 02:16:48 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-21 02:21:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/243703005/1
6 years, 8 months ago (2014-04-21 02:21:51 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-21 03:20:49 UTC) #5
Message was sent while issue was closed.
Change committed as 264962

Powered by Google App Engine
This is Rietveld 408576698