Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2436813005:
Update Skia GL bindings to ES3 (Closed)
DescriptionUpdate Skia GL bindings to ES3
The bindings are updated to include ES3 functions. However, the context that is created for GPU rasterization is still ES2 so this should have no effect. An ugly version string hack that was temporarily needed to restrict Skia to ES2 is removed as it is no longer necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
BUG=651829
Review-Url: https://codereview.chromium.org/2436813005
Cr-Commit-Position: refs/heads/master@{#469018}
Committed: https://chromium.googlesource.com/chromium/src/+/96a53c163a05f4d0f6ce201d685a7f335fb3de99
Patch Set 1 #Patch Set 2 : rebase and update #Patch Set 3 : rebase #Patch Set 4 : update #Patch Set 5 : rebase #Patch Set 6 : just bindings #Messages
Total messages: 25 (20 generated)
Description was changed from ========== WIP, Bind Skia to GLES3 ========== to ========== WIP, Bind Skia to GLES3 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== WIP, Bind Skia to GLES3 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== WIP, Bind Skia to GLES3 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel BUG=651829 ==========
Description was changed from ========== WIP, Bind Skia to GLES3 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel BUG=651829 ========== to ========== WIP, Bind Skia to GLES3 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel BUG=651829 ==========
The CQ bit was checked by bsalomon@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by bsalomon@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
Description was changed from ========== WIP, Bind Skia to GLES3 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel BUG=651829 ========== to ========== Update Skia GL bindings to ES3 The bindings are updated to include ES3 functions. However, the context that is created for GPU rasterization is still ES2 so this should have no effect. An ugly version string hack that was temporarily needed to restrict Skia to ES2 is removed as it is no longer necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel BUG=651829 ==========
bsalomon@google.com changed reviewers: + zmo@google.com
The CQ bit was checked by bsalomon@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/26 13:46:12, bsalomon wrote: lgtm if you are ready please watch out for potential perf regressions
On 2017/05/03 15:58:13, Zhenyao Mo wrote: > On 2017/04/26 13:46:12, bsalomon wrote: > > lgtm if you are ready > > please watch out for potential perf regressions Will do, but this actually just adds the bindings for the ES3 functions. Skia will still be using a context created as ES2. I encountered a bunch of unit test failures when I tried enabling the ES3 context (patchset 5). I reproduced some locally where Skia was still limited to ES2 using the GL string hack removed by this CL so I don't think they're Skia related.
The CQ bit was checked by bsalomon@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493827811913750,
"parent_rev": "2de1cc0bc6bfc831331f083e8434f15c11ad9021", "commit_rev":
"96a53c163a05f4d0f6ce201d685a7f335fb3de99"}
Message was sent while issue was closed.
Description was changed from ========== Update Skia GL bindings to ES3 The bindings are updated to include ES3 functions. However, the context that is created for GPU rasterization is still ES2 so this should have no effect. An ugly version string hack that was temporarily needed to restrict Skia to ES2 is removed as it is no longer necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel BUG=651829 ========== to ========== Update Skia GL bindings to ES3 The bindings are updated to include ES3 functions. However, the context that is created for GPU rasterization is still ES2 so this should have no effect. An ugly version string hack that was temporarily needed to restrict Skia to ES2 is removed as it is no longer necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel BUG=651829 Review-Url: https://codereview.chromium.org/2436813005 Cr-Commit-Position: refs/heads/master@{#469018} Committed: https://chromium.googlesource.com/chromium/src/+/96a53c163a05f4d0f6ce201d685a... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/96a53c163a05f4d0f6ce201d685a... |
