Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2436763003: [DevTools] Remove Browser domain, switch clients to Target. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 1 month ago
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove Browser domain, switch clients to Target. BUG=648775 Committed: https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e Cr-Commit-Position: refs/heads/master@{#427483}

Patch Set 1 #

Patch Set 2 : fixed tests #

Patch Set 3 : include, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -529 lines) Patch
M content/browser/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D content/browser/devtools/protocol/browser_handler.h View 1 chunk +0 lines, -76 lines 0 comments Download
D content/browser/devtools/protocol/browser_handler.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/schema_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/target_handler.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/target_handler.cc View 1 7 chunks +63 lines, -21 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M headless/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_devtools_client_impl.h View 6 chunks +3 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_devtools_client_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M headless/lib/browser/headless_devtools_manager_delegate.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M headless/lib/headless_devtools_client_browsertest.cc View 12 chunks +112 lines, -105 lines 0 comments Download
M headless/public/headless_devtools_client.h View 4 chunks +4 lines, -4 lines 0 comments Download
M headless/public/util/dom_tree_extractor_browsertest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 10 chunks +67 lines, -125 lines 0 comments Download

Messages

Total messages: 35 (24 generated)
dgozman
Could you please take a look?
4 years, 2 months ago (2016-10-21 00:52:41 UTC) #12
pfeldman
lgtm
4 years, 2 months ago (2016-10-21 01:02:44 UTC) #13
dgozman
Alex, could you please take a look?
4 years, 2 months ago (2016-10-21 17:56:05 UTC) #19
alex clarke (OOO till 29th)
Looks like the headless bot is currently transitioning to a release version on the main ...
4 years, 1 month ago (2016-10-24 10:07:33 UTC) #20
Sami
FYI looks like headless/public/util/dom_tree_extractor_browsertest.cc needs some updates for this.
4 years, 1 month ago (2016-10-25 17:48:34 UTC) #21
dgozman
On 2016/10/25 17:48:34, Sami wrote: > FYI looks like headless/public/util/dom_tree_extractor_browsertest.cc needs some > updates for ...
4 years, 1 month ago (2016-10-25 18:46:47 UTC) #22
alex clarke (OOO till 29th)
On 2016/10/25 18:46:47, dgozman wrote: > On 2016/10/25 17:48:34, Sami wrote: > > FYI looks ...
4 years, 1 month ago (2016-10-25 19:54:10 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436763003/40001
4 years, 1 month ago (2016-10-25 21:26:36 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-25 21:34:25 UTC) #32
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e Cr-Commit-Position: refs/heads/master@{#427483}
4 years, 1 month ago (2016-10-25 21:36:02 UTC) #34
dgozman
4 years, 1 month ago (2016-10-25 21:38:31 UTC) #35
Message was sent while issue was closed.
On 2016/10/25 19:54:10, alex clarke wrote:
> On 2016/10/25 18:46:47, dgozman wrote:
> > On 2016/10/25 17:48:34, Sami wrote:
> > > FYI looks like headless/public/util/dom_tree_extractor_browsertest.cc
needs
> > some
> > > updates for this.
> > 
> > Thanks, unnecessary include sneaked in! Please take another look.
> 
> I patched this in locally and the headless_browsertests pass. LGTM

Thank you for review!

Powered by Google App Engine
This is Rietveld 408576698