Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2436763003: [DevTools] Remove Browser domain, switch clients to Target. (Closed)
Patch Set: include, rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index d107492eb7e842f279886b00bc473455dc8effb9..73550d88d575e6efd812f9273068d3262389233a 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -944,7 +944,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, BrowserCreateAndCloseTarget) {
EXPECT_EQ(1u, shell()->windows().size());
std::unique_ptr<base::DictionaryValue> params(new base::DictionaryValue());
params->SetString("url", "about:blank");
- SendCommand("Browser.createTarget", std::move(params), true);
+ SendCommand("Target.createTarget", std::move(params), true);
std::string target_id;
EXPECT_TRUE(result_->GetString("targetId", &target_id));
EXPECT_EQ(2u, shell()->windows().size());
@@ -954,7 +954,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, BrowserCreateAndCloseTarget) {
bool success;
params.reset(new base::DictionaryValue());
params->SetString("targetId", target_id);
- SendCommand("Browser.closeTarget", std::move(params), true);
+ SendCommand("Target.closeTarget", std::move(params), true);
EXPECT_TRUE(result_->GetBoolean("success", &success));
EXPECT_TRUE(success);
}
@@ -962,9 +962,9 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, BrowserCreateAndCloseTarget) {
IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, BrowserGetTargets) {
NavigateToURLBlockUntilNavigationsComplete(shell(), GURL("about:blank"), 1);
Attach();
- SendCommand("Browser.getTargets", nullptr, true);
+ SendCommand("Target.getTargets", nullptr, true);
base::ListValue* target_infos;
- EXPECT_TRUE(result_->GetList("targetInfo", &target_infos));
+ EXPECT_TRUE(result_->GetList("targetInfos", &target_infos));
EXPECT_EQ(1u, target_infos->GetSize());
base::DictionaryValue* target_info;
EXPECT_TRUE(target_infos->GetDictionary(0u, &target_info));
« no previous file with comments | « content/browser/devtools/protocol/browser_handler.cc ('k') | content/browser/devtools/protocol/schema_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698