src/ia32/full-codegen-ia32.cc - Issue 24366004: Split HCompareGeneric in a test and a branch part.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 24366004: Split HCompareGeneric in a test and a branch part. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 5250f4b44ffac099f403d598ad35a7e351d99974..1e980ef224cf3c187a838a5c2e27d5199392e79c 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -4708,7 +4708,7 @@ void FullCodeGenerator::VisitCompareOperation(CompareOperation* expr) {

CallIC(ic, RelocInfo::CODE_TARGET, expr->CompareOperationFeedbackId());

patch_site.EmitPatchInfo();

- PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);

+ if (!context()->IsEffect()) PrepareForBailout(expr, TOS_REG);

__ test(eax, eax);

Split(cc, if_true, if_false, fall_through);

}