Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 24366004: Split HCompareGeneric in a test and a branch part. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4690 matching lines...) Expand 10 before | Expand all | Expand 10 after
4701 Split(cc, if_true, if_false, NULL); 4701 Split(cc, if_true, if_false, NULL);
4702 __ bind(&slow_case); 4702 __ bind(&slow_case);
4703 } 4703 }
4704 4704
4705 // Record position and call the compare IC. 4705 // Record position and call the compare IC.
4706 SetSourcePosition(expr->position()); 4706 SetSourcePosition(expr->position());
4707 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op); 4707 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op);
4708 CallIC(ic, RelocInfo::CODE_TARGET, expr->CompareOperationFeedbackId()); 4708 CallIC(ic, RelocInfo::CODE_TARGET, expr->CompareOperationFeedbackId());
4709 patch_site.EmitPatchInfo(); 4709 patch_site.EmitPatchInfo();
4710 4710
4711 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 4711 if (!context()->IsEffect()) PrepareForBailout(expr, TOS_REG);
4712 __ test(eax, eax); 4712 __ test(eax, eax);
4713 Split(cc, if_true, if_false, fall_through); 4713 Split(cc, if_true, if_false, fall_through);
4714 } 4714 }
4715 } 4715 }
4716 4716
4717 // Convert the result of the comparison into one expected for this 4717 // Convert the result of the comparison into one expected for this
4718 // expression's context. 4718 // expression's context.
4719 context()->Plug(if_true, if_false); 4719 context()->Plug(if_true, if_false);
4720 } 4720 }
4721 4721
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
4969 ASSERT_EQ(kJnsOffset, *(call_target_address - 2)); 4969 ASSERT_EQ(kJnsOffset, *(call_target_address - 2));
4970 return INTERRUPT; 4970 return INTERRUPT;
4971 } 4971 }
4972 } 4972 }
4973 #endif // DEBUG 4973 #endif // DEBUG
4974 4974
4975 4975
4976 } } // namespace v8::internal 4976 } } // namespace v8::internal
4977 4977
4978 #endif // V8_TARGET_ARCH_IA32 4978 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698