Issue 24366004: Split HCompareGeneric in a test and a branch part.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24366004: Split HCompareGeneric in a test and a branch part. (Closed)

Created:
7 years, 2 months ago by oliv

Modified:
7 years ago

Reviewers:

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Split HCompareGeneric in a test and a branch part. A similar approach can now be taken with all other branching instructions. BUG=

Patch Set 1 : #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+533 lines, -104 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/arm/lithium-arm.h	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	4 chunks	+30 lines, -29 lines	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.h	View	1 chunk	+13 lines, -0 lines	1 comment	Download
M	src/hydrogen.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View	3 chunks	+31 lines, -4 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	4 chunks	+30 lines, -29 lines	1 comment	Download
M	src/ia32/lithium-ia32.h	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	4 chunks	+38 lines, -37 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	test/mjsunit/compare-generic.js	View	1 chunk	+311 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

oliv

Hey, so this is a much cleaner approach than having control instructions with side effects, ...

7 years, 2 months ago (2013-09-25 11:00:02 UTC) #1

titzer

7 years, 2 months ago (2013-10-10 14:05:25 UTC) #2

https://codereview.chromium.org/24366004/diff/13001/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/24366004/diff/13001/src/hydrogen.h#newcode1212
src/hydrogen.h:1212: HAndBranch* AndBranch(HInstruction* pluggable,
Need a better name than "pluggable"

https://codereview.chromium.org/24366004/diff/13001/src/ia32/lithium-codegen-...
File src/ia32/lithium-codegen-ia32.cc (right):

https://codereview.chromium.org/24366004/diff/13001/src/ia32/lithium-codegen-...
src/ia32/lithium-codegen-ia32.cc:3068: __ nop();
What's the nop for?

Expand Messages | Collapse Messages