Bash completion support for --gtest_* and --test-launcher-* cmdline switches.

Bash completion support for --gtest_* and --test-launcher-* cmdline switches.

BUG=none

Committed: https://crrev.com/b2789fbec7c404a77be5b1b5bde9aa47306dbf33
Cr-Commit-Position: refs/heads/master@{#426342}

[Łukasz Anforowicz, 2016-10-19 22:21:33]

lukasza@chromium.org changed reviewers:
+ enne@chromium.org

[Łukasz Anforowicz, 2016-10-19 22:21:34]

enne@, could you PTAL?

On my machine the new code takes ~0.2sec to execute.  I hope this is okay for
people sourcing this file.  If not, then we can consider having 2 separate files
under bash-completion directory (chrome-completion + gtest-completion) as
suggested by thakis@ in https://crrev.com/9320075#msg11, but moving the file
will break people using it today...

WDYT?

[enne (OOO), 2016-10-19 22:28:54]

This seems reasonable to me.

lgtm, for what it's worth.

[Łukasz Anforowicz, 2016-10-19 22:35:58]

lukasza@chromium.org changed reviewers:
+ dpranke@chromium.org

[Łukasz Anforowicz, 2016-10-19 22:35:58]

dpranke@, could you PTAL?

[Dirk Pranke, 2016-10-19 22:41:41]

On 2016/10/19 22:35:58, Łukasz Anforowicz wrote:
> dpranke@, could you PTAL?

Hm. 0.2s seems surprisingly fast; I'd guess that's with a warm filesystem cache
on Linux, and on Mac (or with a cold cache) it'd be substantially slower.

I'd guess you could always wrap the for loop in a function and then have people
who wanted it call the function after sourcing the file (or something) if
it turned out to be an issue.

That said, I don't use this file so I don't care too much :). LGTM and we can
see if people complain ...

[Łukasz Anforowicz, 2016-10-19 23:08:33]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-10-19 23:09:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 00:00:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:13:27]

Description was changed from

==========
Bash completion support for --gtest_* and --test-launcher-* cmdline switches.

BUG=none
==========

to

==========
Bash completion support for --gtest_* and --test-launcher-* cmdline switches.

BUG=none

Committed: https://crrev.com/b2789fbec7c404a77be5b1b5bde9aa47306dbf33
Cr-Commit-Position: refs/heads/master@{#426342}
==========

[commit-bot: I haz the power, 2016-10-21 13:13:28]

Patchset 1 (id:??) landed as
https://crrev.com/b2789fbec7c404a77be5b1b5bde9aa47306dbf33
Cr-Commit-Position: refs/heads/master@{#426342}