third_party/WebKit/public/platform/modules/push_messaging/WebPushError.h - Issue 2436393002: Disallow repeated PushManager.subscribes with different sender ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/push_messaging/WebPushError.h

Issue 2436393002: Disallow repeated PushManager.subscribes with different sender ids (Closed)

Patch Set: Make error message more informative Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/public/platform/modules/push_messaging/WebPushError.h

diff --git a/third_party/WebKit/public/platform/modules/push_messaging/WebPushError.h b/third_party/WebKit/public/platform/modules/push_messaging/WebPushError.h

index 1a600e65f8cae55c4e4e6605311d919ba6ceef71..82d40b449a5ec7d4bd412e1c062b3c4fc3970d11 100644

--- a/third_party/WebKit/public/platform/modules/push_messaging/WebPushError.h

+++ b/third_party/WebKit/public/platform/modules/push_messaging/WebPushError.h

@@ -17,7 +17,8 @@ struct WebPushError {

ErrorTypeNotFound,

ErrorTypeNotSupported,

ErrorTypeUnknown,

- ErrorTypeLast = ErrorTypeUnknown

+ ErrorTypeInvalidState,

+ ErrorTypeLast = ErrorTypeInvalidState

};

WebPushError(ErrorType errorType, const WebString& message)

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushError.cpp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »