third_party/WebKit/Source/modules/push_messaging/PushError.cpp - Issue 2436393002: Disallow repeated PushManager.subscribes with different sender ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushError.cpp

Issue 2436393002: Disallow repeated PushManager.subscribes with different sender ids (Closed)

Patch Set: Make error message more informative Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/push_messaging/PushError.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushError.cpp b/third_party/WebKit/Source/modules/push_messaging/PushError.cpp

index 16d6c09e0cf4f61efe85ab5e628c048ae68c2807..7d7dc8996ef5b198cd6bd76e9669f6ff1ed93279 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushError.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushError.cpp

@@ -15,6 +15,8 @@ DOMException* PushError::take(ScriptPromiseResolver*,

switch (webError.errorType) {

case WebPushError::ErrorTypeAbort:

return DOMException::create(AbortError, webError.message);

+ case WebPushError::ErrorTypeInvalidState:

+ return DOMException::create(InvalidStateError, webError.message);

case WebPushError::ErrorTypeNetwork:

return DOMException::create(NetworkError, webError.message);

case WebPushError::ErrorTypeNotAllowed: