Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: content/public/common/push_messaging_status.h

Issue 2436393002: Disallow repeated PushManager.subscribes with different sender ids (Closed)
Patch Set: Make error message more informative Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/push_messaging/push_provider.cc ('k') | content/public/common/push_messaging_status.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/push_messaging_status.h
diff --git a/content/public/common/push_messaging_status.h b/content/public/common/push_messaging_status.h
index 8b9fb0a32ba79750e4a296e6fd62960e9bc159d7..d8d7e7e1089724eefc0466b900dfb25fa696f3b0 100644
--- a/content/public/common/push_messaging_status.h
+++ b/content/public/common/push_messaging_status.h
@@ -57,13 +57,16 @@ enum PushRegistrationStatus {
// empty.
PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING = 12,
+ // Registration failed because a subscription with a different sender id
+ // already exists.
+ PUSH_REGISTRATION_STATUS_SENDER_ID_MISMATCH = 13,
+
// NOTE: Do not renumber these as that would confuse interpretation of
// previously logged data. When making changes, also update the enum list
// in tools/metrics/histograms/histograms.xml to keep it in sync, and
// update PUSH_REGISTRATION_STATUS_LAST below.
- PUSH_REGISTRATION_STATUS_LAST =
- PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING
+ PUSH_REGISTRATION_STATUS_LAST = PUSH_REGISTRATION_STATUS_SENDER_ID_MISMATCH
};
// Push unregistration reason for reporting in UMA. Enum values can be added,
« no previous file with comments | « content/child/push_messaging/push_provider.cc ('k') | content/public/common/push_messaging_status.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698