content/child/push_messaging/push_provider.cc - Issue 2436393002: Disallow repeated PushManager.subscribes with different sender ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/push_messaging/push_provider.cc

Issue 2436393002: Disallow repeated PushManager.subscribes with different sender ids (Closed)

Patch Set: Make error message more informative Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/push_messaging/push_provider.cc

diff --git a/content/child/push_messaging/push_provider.cc b/content/child/push_messaging/push_provider.cc

index 2f0293ef2345cdf5a652ee90a2070148b4b62bfb..0a92c28296023fea558a33872130d4065af5a36c 100644

--- a/content/child/push_messaging/push_provider.cc

+++ b/content/child/push_messaging/push_provider.cc

@@ -46,6 +46,9 @@ blink::WebPushError PushRegistrationStatusToWebPushError(

case PUSH_REGISTRATION_STATUS_PERMISSION_DENIED:

error_type = blink::WebPushError::ErrorTypeNotAllowed;

break;

+ case PUSH_REGISTRATION_STATUS_SENDER_ID_MISMATCH:

+ error_type = blink::WebPushError::ErrorTypeInvalidState;

+ break;

case PUSH_REGISTRATION_STATUS_SUCCESS_FROM_PUSH_SERVICE:

case PUSH_REGISTRATION_STATUS_NO_SERVICE_WORKER:

case PUSH_REGISTRATION_STATUS_SERVICE_NOT_AVAILABLE: