Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Issue 2436183002: Write transparent pixels more often (SkGifCodec) (Closed)

Created:
4 years, 2 months ago by scroggo_chromium
Modified:
4 years, 1 month ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Write transparent pixels more often (SkGifCodec) Writing transparent pixels is faster than the alternative, and we can skip clearing the frame to transparent. We'll still clear if the image is incomplete. I ran ./out/Release/nanobench --images <images> --samples 100 --sourceType image --simpleCodec -v over the GIFs we have on our bots, and found an average ~13% speedup. Raw data is on sheet 2 of https://docs.google.com/spreadsheets/d/19V-t9BfbFw5eiwBTKA1qOBkZbchjlTC5EIz6HFy-6RI/ (the sheet is named WriteTransparentPixels). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2436183002 Committed: https://skia.googlesource.com/skia/+/1285f413950910782d5439b5072ccfa14bdf80f7

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/codec/SkGifCodec.cpp View 1 2 chunks +4 lines, -11 lines 0 comments Download
M third_party/gif/SkGifImageReader.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/gif/SkGifImageReader.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
scroggo
4 years, 2 months ago (2016-10-20 20:32:03 UTC) #3
msarett
lgtm
4 years, 2 months ago (2016-10-20 20:39:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436183002/20001
4 years, 1 month ago (2016-10-26 20:27:39 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 20:48:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1285f413950910782d5439b5072ccfa14bdf80f7

Powered by Google App Engine
This is Rietveld 408576698