Fix decoding GIF to 565

Fix decoding GIF to 565

565 cannot take the !writeTransparentPixels path, so disable it for
cases where we might have to take that path.

This only affects frames beyond the first. If the first frame has
a transparent pixel, it will be marked as non-opaque, so we cannot
decode to 565 anyway.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2441833002

Committed: https://skia.googlesource.com/skia/+/53f63b69e83fd805418d72a6eeb860cf0fcff3c5

[scroggo_chromium, 2016-10-20 21:09:44]

Description was changed from

==========
Fix decoding GIF to 565

565 cannot take the !writeTransparentPixels path, so disable it for
cases where we might have to take that path.

This only affects frames beyond the first. If the first frame has
a transparent pixel, it will be marked as non-opaque, so we cannot
decode to 565 anyway.
==========

to

==========
Fix decoding GIF to 565

565 cannot take the !writeTransparentPixels path, so disable it for
cases where we might have to take that path.

This only affects frames beyond the first. If the first frame has
a transparent pixel, it will be marked as non-opaque, so we cannot
decode to 565 anyway.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2441833002
==========

[scroggo_chromium, 2016-10-20 21:11:05]

scroggo@chromium.org changed reviewers:
+ msarett@google.com

[msarett, 2016-10-20 21:32:25]

lgtm

[scroggo, 2016-10-26 20:34:49]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-10-26 20:34:49]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com
Link to the patchset: https://codereview.chromium.org/2441833002/#ps40001
(title: "Add comment that the switch case fall through is intentional")

[commit-bot: I haz the power, 2016-10-26 20:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:35:01]

This CL has an open dependency (Issue 2436183002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[scroggo, 2016-10-26 20:52:48]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2016-10-26 20:52:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:01:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 21:01:27]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[scroggo_chromium, 2016-10-27 15:02:32]

Please take another look.

I forgot about a case where an opaque image is interlaced, and the latest patch
fixes that. (Luckily our bot had exactly such an image to catch me!)

[scroggo_chromium, 2016-10-27 15:03:27]

The CQ bit was checked by scroggo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 15:03:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarett, 2016-10-27 15:11:43]

lgtm

[commit-bot: I haz the power, 2016-10-27 15:24:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 15:24:48]

Dry run: This issue passed the CQ dry run.

[scroggo, 2016-10-27 15:28:15]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2016-10-27 15:28:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 15:29:15]

Description was changed from

==========
Fix decoding GIF to 565

565 cannot take the !writeTransparentPixels path, so disable it for
cases where we might have to take that path.

This only affects frames beyond the first. If the first frame has
a transparent pixel, it will be marked as non-opaque, so we cannot
decode to 565 anyway.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2441833002
==========

to

==========
Fix decoding GIF to 565

565 cannot take the !writeTransparentPixels path, so disable it for
cases where we might have to take that path.

This only affects frames beyond the first. If the first frame has
a transparent pixel, it will be marked as non-opaque, so we cannot
decode to 565 anyway.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2441833002

Committed:
https://skia.googlesource.com/skia/+/53f63b69e83fd805418d72a6eeb860cf0fcff3c5
==========

[commit-bot: I haz the power, 2016-10-27 15:29:16]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/53f63b69e83fd805418d72a6eeb860cf0fcff3c5