Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2436113003: Update aspirational_scripts per Unicode 9 (Closed)

Created:
4 years, 2 months ago by jungshik at Google
Modified:
4 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update aspirational_scripts per Unicode 9 This is a preparation to update ICU to 58.1. Without this change, ICU update CL cannot be tested on trybots because a compile will fail due to '#error' checking if ICU version is less than 58. BUG=637001 TEST=None TBR=pkasting@chromium.org Committed: https://crrev.com/424584b4984bde7c831f42e9fb47f1ad583a1c46 Cr-Commit-Position: refs/heads/master@{#426749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M components/url_formatter/url_formatter.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jungshik at Google
There's virtually no change (except for one code point) in aspirational scripts between Unicode 8 ...
4 years, 2 months ago (2016-10-21 06:58:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436113003/1
4 years, 2 months ago (2016-10-21 06:59:22 UTC) #3
Peter Kasting
LGTM
4 years, 2 months ago (2016-10-21 07:01:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 08:16:14 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:28:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/424584b4984bde7c831f42e9fb47f1ad583a1c46
Cr-Commit-Position: refs/heads/master@{#426749}

Powered by Google App Engine
This is Rietveld 408576698