Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 24360017: Expose SameValue equality comparison algorithm (Closed)

Created:
7 years, 3 months ago by yusukesuzuki
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Expose SameValue equality comparison algorithm Since SameValue algorithm is defined formally in ECMA262 and V8 already exported Equals and StrictEquals algorithms, SameValue should be exposed. And in this issue, we fix the issue of Object::SameValue implementation, SameValue(0.0, -0.0) returnes true. BUG=v8:2909 TEST=cctest/test-api/Equality R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16924

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M include/v8.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +5 lines, -2 lines 1 comment Download
M test/cctest/test-api.cc View 2 chunks +11 lines, -1 line 3 comments Download

Messages

Total messages: 4 (0 generated)
yusukesuzuki
V8 issue is here[1]. [1]: https://code.google.com/p/v8/issues/detail?id=2909
7 years, 3 months ago (2013-09-24 12:54:43 UTC) #1
yusukesuzuki
https://chromiumcodereview.appspot.com/24360017/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/24360017/diff/1/src/objects.cc#newcode1012 src/objects.cc:1012: return (this_value != 0) || ((1 / this_value) == ...
7 years, 3 months ago (2013-09-24 12:58:26 UTC) #2
Michael Starzinger
LGTM. I'll land this.
7 years, 3 months ago (2013-09-24 16:32:45 UTC) #3
Michael Starzinger
7 years, 3 months ago (2013-09-24 16:51:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698