Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4582)

Unified Diff: chrome/browser/plugins/flash_download_interception_unittest.cc

Issue 2435933002: Don't intercept Flash navigations when the current page is the Flash download page. (Closed)
Patch Set: Don't intercept Flash navigations when the current page is the Flash download page. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/flash_download_interception.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/flash_download_interception_unittest.cc
diff --git a/chrome/browser/plugins/flash_download_interception_unittest.cc b/chrome/browser/plugins/flash_download_interception_unittest.cc
index 08ad6c2e392652906eb9ef0c3850b7c954d619b9..068871d137d700e31213b9216cb31c664ede017d 100644
--- a/chrome/browser/plugins/flash_download_interception_unittest.cc
+++ b/chrome/browser/plugins/flash_download_interception_unittest.cc
@@ -73,6 +73,11 @@ TEST_F(FlashDownloadInterceptionTest, DownloadUrlVariations) {
EXPECT_FALSE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
host_content_settings_map(), GURL("http://source-page.com"),
GURL("http://ww.macromedia.com/go/getflashplayer"), true));
+
+ // Don't intercept navigations occurring on the flash download page.
+ EXPECT_FALSE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
+ host_content_settings_map(), GURL("https://get.adobe.com/flashplayer/"),
+ GURL("https://get.adobe.com/flashplayer/"), true));
}
TEST_F(FlashDownloadInterceptionTest, NavigationThrottleCancelsNavigation) {
« no previous file with comments | « chrome/browser/plugins/flash_download_interception.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698