Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2435873004: [Extensions] Remove unused version of ScriptContext::CallFunction() (Closed)

Created:
4 years, 2 months ago by Devlin
Modified:
4 years, 1 month ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove unused version of ScriptContext::CallFunction() ScriptContext::CallFunction() is deprecated. Remove an unused override of the function. BUG=629431 Committed: https://crrev.com/12a457ebc796770d6da36efb0d3fb3797e1a9c47 Cr-Commit-Position: refs/heads/master@{#427457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M extensions/renderer/script_context.h View 1 chunk +3 lines, -6 lines 0 comments Download
M extensions/renderer/script_context.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Devlin
4 years, 1 month ago (2016-10-25 20:28:03 UTC) #6
lazyboy
lgtm
4 years, 1 month ago (2016-10-25 20:29:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435873004/1
4 years, 1 month ago (2016-10-25 20:34:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 20:40:23 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 20:42:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12a457ebc796770d6da36efb0d3fb3797e1a9c47
Cr-Commit-Position: refs/heads/master@{#427457}

Powered by Google App Engine
This is Rietveld 408576698