Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: extensions/renderer/script_context.h

Issue 2435873004: [Extensions] Remove unused version of ScriptContext::CallFunction() (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/script_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_context.h
diff --git a/extensions/renderer/script_context.h b/extensions/renderer/script_context.h
index ae06dfc77f0aab43640bcc5601f4c9d641396dca..197ed3a180b213ec5264e5022c6d4704934bc609 100644
--- a/extensions/renderer/script_context.h
+++ b/extensions/renderer/script_context.h
@@ -108,18 +108,15 @@ class ScriptContext : public RequestSender::Source {
// the context is in the process of being destroyed.
content::RenderFrame* GetRenderFrame() const;
- // Runs |function| with appropriate scopes. Doesn't catch exceptions, callers
- // must do that if they want.
- //
- // USE THIS METHOD RATHER THAN v8::Function::Call WHEREVER POSSIBLE.
+ // DEPRECATED.
v8::Local<v8::Value> CallFunction(const v8::Local<v8::Function>& function,
int argc,
v8::Local<v8::Value> argv[]) const;
- v8::Local<v8::Value> CallFunction(
- const v8::Local<v8::Function>& function) const;
// Safely calls the v8::Function, respecting the page load deferrer and
// possibly executing asynchronously.
+ // Doesn't catch exceptions; callers must do that if they want.
+ // USE THIS METHOD RATHER THAN v8::Function::Call WHEREVER POSSIBLE.
// TODO(devlin): Remove the above variants in favor of this.
void SafeCallFunction(const v8::Local<v8::Function>& function,
int argc,
« no previous file with comments | « no previous file | extensions/renderer/script_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698