Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2435873003: [WeakMemoryCache] Do not prune in didAccessDecodedData() (Closed)

Created:
4 years, 2 months ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
Nate Chapin, yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WeakMemoryCache] Do not prune in didAccessDecodedData() Preparation for removing didAccessDecodedData() in https://codereview.chromium.org/2411243004. BUG=603462 Committed: https://crrev.com/fd61ca3f63c0640f4606dd9d93bcd681b5dfb6dd Cr-Commit-Position: refs/heads/master@{#427267}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (16 generated)
hiroshige
PTAL.
4 years, 2 months ago (2016-10-21 05:40:46 UTC) #5
Nate Chapin
LGTM, but I'm curious: why is this a separate patch?
4 years, 2 months ago (2016-10-21 18:33:01 UTC) #6
hiroshige
On 2016/10/21 18:33:01, Nate Chapin wrote: > LGTM, but I'm curious: why is this a ...
4 years, 1 month ago (2016-10-24 03:28:00 UTC) #7
yhirano
lgtm
4 years, 1 month ago (2016-10-24 08:15:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435873003/40001
4 years, 1 month ago (2016-10-24 10:31:45 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/301258)
4 years, 1 month ago (2016-10-24 12:34:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435873003/40001
4 years, 1 month ago (2016-10-25 03:10:51 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-25 03:46:05 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 03:49:35 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fd61ca3f63c0640f4606dd9d93bcd681b5dfb6dd
Cr-Commit-Position: refs/heads/master@{#427267}

Powered by Google App Engine
This is Rietveld 408576698