Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 2416803002: Remove unused Internals::setMemoryCacheCapacities() (Closed)

Created:
4 years, 2 months ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused Internals::setMemoryCacheCapacities() According to codesearch, there are no usage of setMemoryCacheCapacities from JavaScript in the tests. BUG=603462 Committed: https://crrev.com/df6cf99f8c60d3efb3df84dfa1bd0aed6c791b48 Cr-Commit-Position: refs/heads/master@{#427271}

Patch Set 1 #

Patch Set 2 : Remove Internals::setMemoryCacheCapacities() #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M third_party/WebKit/Source/core/testing/Internals.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 27 (22 generated)
hiroshige
PTAL as a core OWNER.
4 years, 2 months ago (2016-10-21 05:36:28 UTC) #15
Nate Chapin
lgtm
4 years, 2 months ago (2016-10-21 18:32:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416803002/60001
4 years, 1 month ago (2016-10-25 03:56:26 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-25 04:00:44 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 04:04:24 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/df6cf99f8c60d3efb3df84dfa1bd0aed6c791b48
Cr-Commit-Position: refs/heads/master@{#427271}

Powered by Google App Engine
This is Rietveld 408576698