Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 243583002: Always initialize WindowFeatures.{x|y|width|height} (Closed)

Created:
6 years, 8 months ago by dcheng
Modified:
6 years, 8 months ago
Reviewers:
tony
CC:
blink-reviews, earthdok
Visibility:
Public.

Description

Always initialize WindowFeatures.{x|y|width|height} Based on WebKit r166072, which also updates a constructor that Blink r171963 missed. BUG=342591 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M Source/core/page/WindowFeatures.cpp View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
6 years, 8 months ago (2014-04-18 19:09:49 UTC) #1
tony
LGTM
6 years, 8 months ago (2014-04-18 19:16:08 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 8 months ago (2014-04-18 22:18:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/243583002/1
6 years, 8 months ago (2014-04-18 22:18:14 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 23:22:51 UTC) #5
Message was sent while issue was closed.
Change committed as 171984

Powered by Google App Engine
This is Rietveld 408576698