Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: core/fpdfapi/parser/cpdf_document.h

Issue 2435783006: Add CPDF_Document::GetPage() unittests (Closed)
Patch Set: Try fix win Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/parser/cpdf_document.h
diff --git a/core/fpdfapi/parser/cpdf_document.h b/core/fpdfapi/parser/cpdf_document.h
index c557a56013f71da4dc7106ad5faa97eb154c56ae..d35375be6aeab47c06182c56c89ceab3a306b458 100644
--- a/core/fpdfapi/parser/cpdf_document.h
+++ b/core/fpdfapi/parser/cpdf_document.h
@@ -104,6 +104,7 @@ class CPDF_Document : public CPDF_IndirectObjectHolder {
private:
Tom Sepez 2016/10/21 21:33:38 maybe this just becomes protected:, as we have sub
npm 2016/10/21 21:46:00 protected and no friends is preferred then?
Tom Sepez 2016/10/21 21:48:33 either way.
npm 2016/10/21 22:12:03 Done.
friend class CPDF_TestDocument;
+ friend class CPDF_DocumentTest;
Tom Sepez 2016/10/21 21:31:40 nit: can we call this class CPDF_TestDocumentForPa
npm 2016/10/21 22:12:03 Done.
// Retrieve page count information by getting count value from the tree nodes
int RetrievePageCount() const;

Powered by Google App Engine
This is Rietveld 408576698