Add CPDF_Document::GetPage() unittests

core/fpdfapi/parser/cpdf_document.h

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_FPDFAPI_PARSER_CPDF_DOCUMENT_H_
 #define CORE_FPDFAPI_PARSER_CPDF_DOCUMENT_H_
 
 #include <functional>
@@ skipping 84 matching lines @@
   CPDF_Font* AddFont(CFX_Font* pFont, int charset, FX_BOOL bVert);
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
   CPDF_Font* AddWindowsFont(LOGFONTA* pLogFont,
                             FX_BOOL bVert,
                             FX_BOOL bTranslateName = FALSE);
   CPDF_Font* AddWindowsFont(LOGFONTW* pLogFont,
                             FX_BOOL bVert,
                             FX_BOOL bTranslateName = FALSE);
 #endif
 
  private:

[Tom Sepez, 2016/10/21 21:33:38]

maybe this just becomes protected:, as we have subclasses for testing.

[npm, 2016/10/21 21:46:00]

protected and no friends is preferred then?

[Tom Sepez, 2016/10/21 21:48:33]

either way.

[npm, 2016/10/21 22:12:03]

Done.

   friend class CPDF_TestDocument;
+  friend class CPDF_DocumentTest;

[Tom Sepez, 2016/10/21 21:31:40]

nit: can we call this class CPDF_TestDocumentForPages ?

[npm, 2016/10/21 22:12:03]

Done.

 
   // Retrieve page count information by getting count value from the tree nodes
   int RetrievePageCount() const;
   CPDF_Dictionary* FindPDFPage(CPDF_Dictionary* pPages,
                                int iPage,
                                int nPagesToGo,
                                int level);
   int FindPageIndex(CPDF_Dictionary* pNode,
                     uint32_t& skip_count,
                     uint32_t objnum,
@@ skipping 19 matching lines @@
   // TODO(thestig): Figure out why this cannot be a std::unique_ptr.
   CPDF_DocPageData* m_pDocPage;
   std::unique_ptr<CPDF_DocRenderData> m_pDocRender;
   std::unique_ptr<JBig2_DocumentContext> m_pCodecContext;
   std::unique_ptr<CPDF_LinkList> m_pLinksContext;
   CFX_ArrayTemplate<uint32_t> m_PageList;
   CFX_WeakPtr<CFX_ByteStringPool> m_pByteStringPool;
 };
 
 #endif  // CORE_FPDFAPI_PARSER_CPDF_DOCUMENT_H_