Chromium Code Reviews

Issue 24357002: Let SetEntropySource() fail if called after V8::Initialize(). (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Dmitry Lomov (no reviews), Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Let SetEntropySource() fail if called after V8::Initialize(). BUG=v8:2905 R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16889

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments. #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+10 lines, -0 lines)
M include/v8.h View 1 chunk +3 lines, -0 lines 0 comments
M src/api.cc View 1 chunk +7 lines, -0 lines 2 comments

Messages

Total messages: 9 (0 generated)
Benedikt Meurer
PTAL
7 years, 3 months ago (2013-09-23 10:09:07 UTC) #1
Dmitry Lomov (no reviews)
https://codereview.chromium.org/24357002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/24357002/diff/1/include/v8.h#newcode4518 include/v8.h:4518: * calling any other V8-related function. This is vague; ...
7 years, 3 months ago (2013-09-23 11:24:15 UTC) #2
Dmitry Lomov (no reviews)
https://codereview.chromium.org/24357002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/24357002/diff/1/src/api.cc#newcode5189 src/api.cc:5189: if (isolate != NULL && isolate->IsInitialized()) On 2013/09/23 11:24:15, ...
7 years, 3 months ago (2013-09-23 11:25:54 UTC) #3
Benedikt Meurer
PTAL
7 years, 3 months ago (2013-09-23 11:36:12 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/24357002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/24357002/diff/1/include/v8.h#newcode4518 include/v8.h:4518: * calling any other V8-related function. On 2013/09/23 11:24:15, ...
7 years, 3 months ago (2013-09-23 11:36:41 UTC) #5
Dmitry Lomov (no reviews)
LGTM
7 years, 3 months ago (2013-09-23 12:24:54 UTC) #6
Benedikt Meurer
Committed patchset #2 manually as r16889 (presubmit successful).
7 years, 3 months ago (2013-09-23 14:11:44 UTC) #7
Michael Starzinger
Drive-by comment. https://codereview.chromium.org/24357002/diff/8001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/24357002/diff/8001/src/api.cc#newcode5181 src/api.cc:5181: i::Isolate* isolate = i::Isolate::UncheckedCurrent(); We try to ...
7 years, 3 months ago (2013-09-23 14:51:31 UTC) #8
Benedikt Meurer
7 years, 3 months ago (2013-09-23 20:25:51 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/24357002/diff/8001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/24357002/diff/8001/src/api.cc#newcode5181
src/api.cc:5181: i::Isolate* isolate = i::Isolate::UncheckedCurrent();
On 2013/09/23 14:51:31, Michael Starzinger wrote:
> We try to get rid of Isolate::Current, please try not to add new call-site to
> this function.

I know, but there's currently no other way to perform this check. We're planning
to add one, but that'll take some more cleanup time.

Powered by Google App Engine