Let SetEntropySource() fail if called after V8::Initialize().

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 5163 matching lines @@
 
 bool v8::V8::Initialize() {
   i::Isolate* isolate = i::Isolate::UncheckedCurrent();
   if (isolate != NULL && isolate->IsInitialized()) {
     return true;
   }
   return InitializeHelper(isolate);
 }
 
 
-void v8::V8::SetEntropySource(EntropySource entropy_source) {
+bool v8::V8::SetEntropySource(EntropySource entropy_source) {
+  // The entropy source must be set before the library is initialized,
+  // as otherwise not all random number generators will pick up the
+  // entropy source and will fall back to weak entropy instead.
+  i::Isolate* isolate = i::Isolate::UncheckedCurrent();
+  if (isolate != NULL && isolate->IsInitialized())

[Dmitry Lomov (no reviews), 2013/09/23 11:24:15]

Looks like this should be isolate == NULL || !isolate->IsInitialized().

[Dmitry Lomov (no reviews), 2013/09/23 11:25:54]

Nevermind.

+    return false;

[Dmitry Lomov (no reviews), 2013/09/23 11:24:15]

I think just returning false will be ignored (also completely useless for user
program - if the function returns false, there is no way for user program to
recover). I think it will make much more sense to assert this (use ApiCheck
function)

[Benedikt Meurer, 2013/09/23 11:36:41]

Done.

+
   i::RandomNumberGenerator::SetEntropySource(entropy_source);
+  return true;
 }
 
 
 void v8::V8::SetReturnAddressLocationResolver(
       ReturnAddressLocationResolver return_address_resolver) {
   i::V8::SetReturnAddressLocationResolver(return_address_resolver);
 }
 
 
 bool v8::V8::SetFunctionEntryHook(FunctionEntryHook entry_hook) {
@@ skipping 2696 matching lines @@
   Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 } }  // namespace v8::internal